html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/issues/1599#issuecomment-1504276696,https://api.github.com/repos/pydata/xarray/issues/1599,1504276696,IC_kwDOAMm_X85ZqXDY,2448579,2023-04-11T23:43:34Z,2023-04-11T23:43:43Z,MEMBER,"Perhaps we should have `array_to_list: bool` instead. If `False`, we just preserve the underlying array type. Then the user could do `ds.as_numpy().to_dict(array_to_list=False)` to always get numpy arrays as #7739","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170 https://github.com/pydata/xarray/issues/1599#issuecomment-1500454096,https://api.github.com/repos/pydata/xarray/issues/1599,1500454096,IC_kwDOAMm_X85ZbxzQ,2443309,2023-04-07T16:47:09Z,2023-04-07T16:47:09Z,MEMBER,@jmccreight - I don't think there is any specific reason this didn't get done. Still open to contributions here if you are interested.,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170 https://github.com/pydata/xarray/issues/1599#issuecomment-333673706,https://api.github.com/repos/pydata/xarray/issues/1599,333673706,MDEyOklzc3VlQ29tbWVudDMzMzY3MzcwNg==,1217238,2017-10-02T21:42:10Z,2017-10-02T21:42:31Z,MEMBER,"@nicain myself, @jhamman and/or @MaximilianR are good choices for reviewers, thanks!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170 https://github.com/pydata/xarray/issues/1599#issuecomment-333658466,https://api.github.com/repos/pydata/xarray/issues/1599,333658466,MDEyOklzc3VlQ29tbWVudDMzMzY1ODQ2Ng==,1217238,2017-10-02T20:41:05Z,2017-10-02T20:52:26Z,MEMBER,"We need to write a contributing guide! But in brief: - We use the NumPy docstring convention: https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt - For unit tests, we use pytest, with helper functions/methods for verifying comparisons between objects. Take a look at the existing tests for examples to emulate: https://github.com/pydata/xarray/blob/25d1855e737444c156f50d1f37a67d9674a8bac5/xarray/tests/test_dataset.py#L2402 See also: https://github.com/pydata/xarray/pull/1485/files","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170 https://github.com/pydata/xarray/issues/1599#issuecomment-333224773,https://api.github.com/repos/pydata/xarray/issues/1599,333224773,MDEyOklzc3VlQ29tbWVudDMzMzIyNDc3Mw==,1217238,2017-09-29T20:00:49Z,2017-09-29T20:00:49Z,MEMBER,"I'll let others chime in on the API design here but yes that sounds pretty reasonable, too.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170 https://github.com/pydata/xarray/issues/1599#issuecomment-333209574,https://api.github.com/repos/pydata/xarray/issues/1599,333209574,MDEyOklzc3VlQ29tbWVudDMzMzIwOTU3NA==,1217238,2017-09-29T18:55:04Z,2017-09-29T18:55:04Z,MEMBER,"We could add a keyword argument to control this, e.g., `numpy=True` to indicate that data should be kept as NumPy arrays.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,261727170