html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1422#issuecomment-305865518,https://api.github.com/repos/pydata/xarray/issues/1422,305865518,MDEyOklzc3VlQ29tbWVudDMwNTg2NTUxOA==,1217238,2017-06-02T17:55:18Z,2017-06-02T17:55:18Z,MEMBER,@benbovy thanks!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,230631480
https://github.com/pydata/xarray/pull/1422#issuecomment-303697667,https://api.github.com/repos/pydata/xarray/issues/1422,303697667,MDEyOklzc3VlQ29tbWVudDMwMzY5NzY2Nw==,4160723,2017-05-24T11:32:40Z,2017-05-24T11:32:40Z,MEMBER,I've tried adding tests for lines in `as_variable` that were not yet covered.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,230631480
https://github.com/pydata/xarray/pull/1422#issuecomment-303635426,https://api.github.com/repos/pydata/xarray/issues/1422,303635426,MDEyOklzc3VlQ29tbWVudDMwMzYzNTQyNg==,1217238,2017-05-24T06:57:57Z,2017-05-24T06:57:57Z,MEMBER,"We have some tests for `as_variable`, but it looks a little thin for public API: https://github.com/pydata/xarray/blob/d80248476ebe4a3845211c5d58e0af1effc73ea3/xarray/tests/test_variable.py#L609
The remaining test failures should be fixed by https://github.com/pydata/xarray/pull/1423","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,230631480
https://github.com/pydata/xarray/pull/1422#issuecomment-303513756,https://api.github.com/repos/pydata/xarray/issues/1422,303513756,MDEyOklzc3VlQ29tbWVudDMwMzUxMzc1Ng==,1217238,2017-05-23T19:56:21Z,2017-05-23T19:56:21Z,MEMBER,"> Mmm I don't see any current use of the copy keyword argument inside the as_variable function. Here is the only place where I found copy to be explicitly provided. Can I safely remove it also there?
Yes, we can safely remove the `copy` argument here. At point point, `as_variable` did not always return a new `Variable` object, but as you can see it always does that now.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,230631480
https://github.com/pydata/xarray/pull/1422#issuecomment-303378994,https://api.github.com/repos/pydata/xarray/issues/1422,303378994,MDEyOklzc3VlQ29tbWVudDMwMzM3ODk5NA==,4160723,2017-05-23T12:13:56Z,2017-05-23T12:13:56Z,MEMBER,"Oh yes I haven't run the tests locally before submitting this, I didn't expected that.
Mmm I don't see any current use of the `copy` keyword argument inside the `as_variable` function. [Here](https://github.com/pydata/xarray/blob/a943419b86c1c952d07cef6acf0b10ea5784a4cc/xarray/core/groupby.py#L542) is the only place where I found `copy` to be explicitly provided. Can I safely remove it also there? If I remove it the tests pass again (although I got 3 remaining failing tests that don't seem to be related to this issue as they fail either with or without the `copy` argument).
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,230631480
https://github.com/pydata/xarray/pull/1422#issuecomment-303371875,https://api.github.com/repos/pydata/xarray/issues/1422,303371875,MDEyOklzc3VlQ29tbWVudDMwMzM3MTg3NQ==,10050469,2017-05-23T11:39:36Z,2017-05-23T11:39:36Z,MEMBER,Many tests fail because they expect to have a ``copy=`` kwarg somehow...,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,230631480