html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/1252#issuecomment-388602324,https://api.github.com/repos/pydata/xarray/issues/1252,388602324,MDEyOklzc3VlQ29tbWVudDM4ODYwMjMyNA==,2443309,2018-05-13T05:17:59Z,2018-05-13T05:17:59Z,MEMBER,"Okay, I'm going to merge now. Hopefully a few of us can stress test this a bit more prior to the next release. Thanks @spencerkclark for all the work here over the past 15 months!!! ","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,205473898 https://github.com/pydata/xarray/pull/1252#issuecomment-388264386,https://api.github.com/repos/pydata/xarray/issues/1252,388264386,MDEyOklzc3VlQ29tbWVudDM4ODI2NDM4Ng==,2443309,2018-05-11T05:33:13Z,2018-05-11T05:33:13Z,MEMBER,Tests are green here now. @shoyer and @spencerkclark - are we waiting on anything else before merging?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,205473898 https://github.com/pydata/xarray/pull/1252#issuecomment-385447271,https://api.github.com/repos/pydata/xarray/issues/1252,385447271,MDEyOklzc3VlQ29tbWVudDM4NTQ0NzI3MQ==,2443309,2018-04-30T16:10:56Z,2018-04-30T16:10:56Z,MEMBER,@spencerkclark - mind reporting the conda issue upstream at https://github.com/conda-forge/cftime-feedstock?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,205473898 https://github.com/pydata/xarray/pull/1252#issuecomment-385088915,https://api.github.com/repos/pydata/xarray/issues/1252,385088915,MDEyOklzc3VlQ29tbWVudDM4NTA4ODkxNQ==,2443309,2018-04-27T20:43:45Z,2018-04-27T20:43:45Z,MEMBER,ping @spencerkclark to finish this up. I just released a new version of cftime so this should be ready to wrap up.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,205473898 https://github.com/pydata/xarray/pull/1252#issuecomment-381131366,https://api.github.com/repos/pydata/xarray/issues/1252,381131366,MDEyOklzc3VlQ29tbWVudDM4MTEzMTM2Ng==,2443309,2018-04-13T13:14:26Z,2018-04-13T13:14:26Z,MEMBER,@spencerkclark - things are well underway fixing up `cftime`. We'll need some namespace changes in xarray before things will work here. Do you want to do those or should I?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,205473898 https://github.com/pydata/xarray/pull/1252#issuecomment-380833398,https://api.github.com/repos/pydata/xarray/issues/1252,380833398,MDEyOklzc3VlQ29tbWVudDM4MDgzMzM5OA==,2443309,2018-04-12T14:51:23Z,2018-04-12T14:51:23Z,MEMBER,I can push the name change on `cftime` forward over the next week. We should really wrap this up.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,205473898 https://github.com/pydata/xarray/pull/1252#issuecomment-373812493,https://api.github.com/repos/pydata/xarray/issues/1252,373812493,MDEyOklzc3VlQ29tbWVudDM3MzgxMjQ5Mw==,2443309,2018-03-16T18:56:50Z,2018-03-16T18:56:50Z,MEMBER,"I'm sufficiently pleased with this that I think we can merge this in more or less its current state. Given the size of the PR though, I'd like to have one more person review it in detail before it goes in. Any takers from @pydata/xarray? Maybe @spencerahill?","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,205473898 https://github.com/pydata/xarray/pull/1252#issuecomment-371988210,https://api.github.com/repos/pydata/xarray/issues/1252,371988210,MDEyOklzc3VlQ29tbWVudDM3MTk4ODIxMA==,2443309,2018-03-10T01:04:38Z,2018-03-10T01:04:38Z,MEMBER,"> there are some failing tests for the zarr backend, but I think those are unrelated (I fixed some that were). Right. Those will be fixed once I merge #1793. ","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,205473898 https://github.com/pydata/xarray/pull/1252#issuecomment-358829484,https://api.github.com/repos/pydata/xarray/issues/1252,358829484,MDEyOklzc3VlQ29tbWVudDM1ODgyOTQ4NA==,2443309,2018-01-19T00:37:00Z,2018-01-19T00:37:00Z,MEMBER,cc @matt-long who was interested in this.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,205473898 https://github.com/pydata/xarray/pull/1252#issuecomment-300547434,https://api.github.com/repos/pydata/xarray/issues/1252,300547434,MDEyOklzc3VlQ29tbWVudDMwMDU0NzQzNA==,2443309,2017-05-10T17:02:17Z,2017-05-10T17:02:17Z,MEMBER,"@spencerkclark - two questions. 1. How is this going? Could you use some help with anything? 2. Pandas provides a convenience function to create arrays of datetime objects (`pd.date_range`). This [function](https://github.com/pandas-dev/pandas/blob/v0.20.1/pandas/core/indexes/datetimes.py#L2040-L2042) just passes its arguments directly on to `DatetimeIndex`. I'm wondering if we can provide an `xr.date_range` function that mimics the pandas version with an additional `calendar` argument? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,205473898 https://github.com/pydata/xarray/pull/1252#issuecomment-296787111,https://api.github.com/repos/pydata/xarray/issues/1252,296787111,MDEyOklzc3VlQ29tbWVudDI5Njc4NzExMQ==,2443309,2017-04-24T18:47:24Z,2017-04-24T18:47:24Z,MEMBER,"My two cents. I think we want: > Always use netcdftime.datetime objects (and hence NetCDFTimeIndex) for representing dates with non-standard calendars Presumably, we can address many of the negatives with this approach with follow-on PRs. The fallback logic in xarray right now for non-standard calendars is not something we want to keep and was mostly meant as a stop-gap until this feature came along. ","{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,205473898