html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1222#issuecomment-274439260,https://api.github.com/repos/pydata/xarray/issues/1222,274439260,MDEyOklzc3VlQ29tbWVudDI3NDQzOTI2MA==,10050469,2017-01-23T09:34:43Z,2017-01-23T09:34:43Z,MEMBER,"> My strongest preference is that all names have the same form, e.g., assert_X_equal, assert_X_identical and assert_X_allclose where X is the same token.

Agreed. Currently X is nothing, but I'm happy with either option you suggest. Also, my docstrings might need a short review as well to make sure I got them right. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,202124581
https://github.com/pydata/xarray/pull/1222#issuecomment-274366291,https://api.github.com/repos/pydata/xarray/issues/1222,274366291,MDEyOklzc3VlQ29tbWVudDI3NDM2NjI5MQ==,1217238,2017-01-22T22:43:10Z,2017-01-22T22:43:10Z,MEMBER,"> As for the names, we currently have three new API-level functions. What about following names?

My strongest preference is that all names have the same form, e.g., `assert_X_equal`, `assert_X_identical` and `assert_X_allclose` where `X` is the same token.

The problem with `assert_data_equal` is that it looks at both data and coords/dims, just not `.data`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,202124581
https://github.com/pydata/xarray/pull/1222#issuecomment-274328972,https://api.github.com/repos/pydata/xarray/issues/1222,274328972,MDEyOklzc3VlQ29tbWVudDI3NDMyODk3Mg==,10050469,2017-01-22T12:49:00Z,2017-01-22T12:49:00Z,MEMBER,"I've implemented your comment and made an effort for better docstring. Let me know what you think.

As for the names, we currently have three new API-level functions. What about following names?
- assert_data_equal (this makes it clear that we look at the data and not the attributes)
- assert_identical (this makes it clear that the objects must be identical)
- assert_allclose 

I'm fine with ``assert_object_identical`` or  ``assert_xarray_identical`` if you wish.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,202124581
https://github.com/pydata/xarray/pull/1222#issuecomment-274230808,https://api.github.com/repos/pydata/xarray/issues/1222,274230808,MDEyOklzc3VlQ29tbWVudDI3NDIzMDgwOA==,1217238,2017-01-21T03:31:01Z,2017-01-21T03:31:01Z,MEMBER,"Also, it would be a good idea to import `testing` in `xarray/__init__.py` so `xr.testing.assert_equal` works without additional imports (e.g., see #1216)
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,202124581
https://github.com/pydata/xarray/pull/1222#issuecomment-274230635,https://api.github.com/repos/pydata/xarray/issues/1222,274230635,MDEyOklzc3VlQ29tbWVudDI3NDIzMDYzNQ==,1217238,2017-01-21T03:28:13Z,2017-01-21T03:28:13Z,MEMBER,"> What do people think about the names of the functions? Numpy includes array as in `assert_array_equal`

I would lean towards `assert_equal`. Maybe `assert_data_equal` or `assert_object_equal`? I guess even `assert_xarray_equal` could be OK, though the name feels redundant to me with the namespace. I would prefer `assert_data_equal`, except that could be confused to only apply to the `.data` attribute.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,202124581
https://github.com/pydata/xarray/pull/1222#issuecomment-274205517,https://api.github.com/repos/pydata/xarray/issues/1222,274205517,MDEyOklzc3VlQ29tbWVudDI3NDIwNTUxNw==,5635139,2017-01-20T23:17:28Z,2017-01-20T23:17:28Z,MEMBER,What do people think about the names of the functions? Numpy includes array as in `assert_array_equal`,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,202124581
https://github.com/pydata/xarray/pull/1222#issuecomment-274198593,https://api.github.com/repos/pydata/xarray/issues/1222,274198593,MDEyOklzc3VlQ29tbWVudDI3NDE5ODU5Mw==,10050469,2017-01-20T22:37:01Z,2017-01-20T22:37:01Z,MEMBER,done,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,202124581
https://github.com/pydata/xarray/pull/1222#issuecomment-274188191,https://api.github.com/repos/pydata/xarray/issues/1222,274188191,MDEyOklzc3VlQ29tbWVudDI3NDE4ODE5MQ==,10050469,2017-01-20T21:45:50Z,2017-01-20T21:45:58Z,MEMBER,"I've implemented the changes you suggested, this is ready for another review.

I 've had problems locally with bottleneck (three tests didn't pass with bottleneck installed), but I haven't been able to reproduce this on travis so I guess it's just me.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,202124581