html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1147#issuecomment-268868297,https://api.github.com/repos/pydata/xarray/issues/1147,268868297,MDEyOklzc3VlQ29tbWVudDI2ODg2ODI5Nw==,5635139,2016-12-22T19:07:08Z,2016-12-22T19:07:08Z,MEMBER,@shoyer green!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192752746
https://github.com/pydata/xarray/pull/1147#issuecomment-268715495,https://api.github.com/repos/pydata/xarray/issues/1147,268715495,MDEyOklzc3VlQ29tbWVudDI2ODcxNTQ5NQ==,5635139,2016-12-22T04:23:49Z,2016-12-22T04:23:49Z,MEMBER,@shoyer green!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192752746
https://github.com/pydata/xarray/pull/1147#issuecomment-268587349,https://api.github.com/repos/pydata/xarray/issues/1147,268587349,MDEyOklzc3VlQ29tbWVudDI2ODU4NzM0OQ==,5635139,2016-12-21T17:35:16Z,2016-12-21T17:35:16Z,MEMBER,@fmaussion had a go - is that what you were thinking?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192752746
https://github.com/pydata/xarray/pull/1147#issuecomment-268435788,https://api.github.com/repos/pydata/xarray/issues/1147,268435788,MDEyOklzc3VlQ29tbWVudDI2ODQzNTc4OA==,5635139,2016-12-21T04:59:30Z,2016-12-21T04:59:30Z,MEMBER,"Rebased on https://github.com/pydata/xarray/pull/1175, so that should be merged first if people agree","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192752746
https://github.com/pydata/xarray/pull/1147#issuecomment-268410195,https://api.github.com/repos/pydata/xarray/issues/1147,268410195,MDEyOklzc3VlQ29tbWVudDI2ODQxMDE5NQ==,5635139,2016-12-21T01:37:30Z,2016-12-21T01:38:31Z,MEMBER,"@shoyer I fixed most of the tests. Will come back and check the remaining few failures

I didn't quite realize how many `.assertVariable...` tests were relying on coercion, so I ended up changing the tests in a lot of places. The test is explicit at the test site, at least.

There were a couple that I think are probably breaks - things like `.argsort` changing the type of a Variable. I marked those with comments but haven't fixed them - or we'll never get this in! Let me know if you have thoughts on any notes","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192752746
https://github.com/pydata/xarray/pull/1147#issuecomment-267456077,https://api.github.com/repos/pydata/xarray/issues/1147,267456077,MDEyOklzc3VlQ29tbWVudDI2NzQ1NjA3Nw==,5635139,2016-12-15T21:56:50Z,2016-12-15T21:56:50Z,MEMBER,"There are more than a dozen: https://travis-ci.org/pydata/xarray/jobs/184356287#L2611

Also some binary / unicode errors - let me know if you have context","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192752746
https://github.com/pydata/xarray/pull/1147#issuecomment-267439370,https://api.github.com/repos/pydata/xarray/issues/1147,267439370,MDEyOklzc3VlQ29tbWVudDI2NzQzOTM3MA==,5635139,2016-12-15T20:46:23Z,2016-12-15T20:46:23Z,MEMBER,"@shoyer do you have ideas for when the types are not the same? For example, many of the tests compare `Variable` to `IndexVariable`. Should we not check types? Add a `check_type=True` argument to the testing functions? Change the tests so they're compliant?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192752746
https://github.com/pydata/xarray/pull/1147#issuecomment-267234900,https://api.github.com/repos/pydata/xarray/issues/1147,267234900,MDEyOklzc3VlQ29tbWVudDI2NzIzNDkwMA==,5635139,2016-12-15T04:17:44Z,2016-12-15T04:17:44Z,MEMBER,"> The last thing I would do is switch the existing test methods like assertDatasetEqual to use these functions, just to reduce the amount of redundant code (and also test your new functions more extensively).

All of tests? I think that's a fairly heavy lift for this PR. It also happens to be really tedious and unfortunately I don't think Find / Replace-able... If you feel strongly I'll plug in and go through though! 

Otherwise we can roll out over time as people write new tests","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192752746
https://github.com/pydata/xarray/pull/1147#issuecomment-266570819,https://api.github.com/repos/pydata/xarray/issues/1147,266570819,MDEyOklzc3VlQ29tbWVudDI2NjU3MDgxOQ==,5635139,2016-12-12T22:17:28Z,2016-12-12T22:17:28Z,MEMBER,@shoyer green,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192752746
https://github.com/pydata/xarray/pull/1147#issuecomment-265805479,https://api.github.com/repos/pydata/xarray/issues/1147,265805479,MDEyOklzc3VlQ29tbWVudDI2NTgwNTQ3OQ==,5635139,2016-12-08T17:46:37Z,2016-12-09T02:05:16Z,MEMBER,Thanks for the feedback! Updated.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192752746
https://github.com/pydata/xarray/pull/1147#issuecomment-264573054,https://api.github.com/repos/pydata/xarray/issues/1147,264573054,MDEyOklzc3VlQ29tbWVudDI2NDU3MzA1NA==,5635139,2016-12-02T21:55:47Z,2016-12-02T21:55:47Z,MEMBER,"Updated.

Is it worth 'testing the tests'? I couldn't find tests for the existing functions","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,192752746