html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1049#issuecomment-257748638,https://api.github.com/repos/pydata/xarray/issues/1049,257748638,MDEyOklzc3VlQ29tbWVudDI1Nzc0ODYzOA==,1217238,2016-11-02T01:35:49Z,2016-11-02T01:35:49Z,MEMBER,"OK, I'm just going to merge this. We can iterate on this more later.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,183218516
https://github.com/pydata/xarray/pull/1049#issuecomment-254814590,https://api.github.com/repos/pydata/xarray/issues/1049,254814590,MDEyOklzc3VlQ29tbWVudDI1NDgxNDU5MA==,10050469,2016-10-19T13:37:21Z,2016-10-19T13:37:21Z,MEMBER,"> You could probably do this by consolidating the two loops over all variables. But up to you if you want to go through the trouble.

@shoyer could you elaborate on that? If there's a way to make it right I am happy to try, but I'm afraid I'm not sure what is the way to go. 
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,183218516
https://github.com/pydata/xarray/pull/1049#issuecomment-254015789,https://api.github.com/repos/pydata/xarray/issues/1049,254015789,MDEyOklzc3VlQ29tbWVudDI1NDAxNTc4OQ==,10050469,2016-10-15T22:49:54Z,2016-10-15T22:49:54Z,MEMBER,"Ok, done. The second problem about the coordinate variable seems trickier to solve though...
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,183218516
https://github.com/pydata/xarray/pull/1049#issuecomment-254005880,https://api.github.com/repos/pydata/xarray/issues/1049,254005880,MDEyOklzc3VlQ29tbWVudDI1NDAwNTg4MA==,1217238,2016-10-15T19:30:15Z,2016-10-15T19:30:15Z,MEMBER,"Alternatively, it looks like the issue is on [line 266](https://github.com/pydata/xarray/blob/62a7f2c00caacb5b917ff320e28aca9cb4396649/xarray/core/combine.py#L268) where we iterate `for k in concat_over`. Instead, we could just do:

```
for k in variables:
    if k in concat_over:
        ...
```

This has the advantage of preserving the set, which is important if there is a very large number of variables.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,183218516
https://github.com/pydata/xarray/pull/1049#issuecomment-254005549,https://api.github.com/repos/pydata/xarray/issues/1049,254005549,MDEyOklzc3VlQ29tbWVudDI1NDAwNTU0OQ==,1217238,2016-10-15T19:25:26Z,2016-10-15T19:25:26Z,MEMBER,"Agreed, this is the better approach. Thanks for diving into this!
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,183218516