html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/990#issuecomment-244844596,https://api.github.com/repos/pydata/xarray/issues/990,244844596,MDEyOklzc3VlQ29tbWVudDI0NDg0NDU5Ng==,1217238,2016-09-06T04:00:25Z,2016-09-06T04:00:25Z,MEMBER,"Thanks!
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,173632183
https://github.com/pydata/xarray/pull/990#issuecomment-244513243,https://api.github.com/repos/pydata/xarray/issues/990,244513243,MDEyOklzc3VlQ29tbWVudDI0NDUxMzI0Mw==,1217238,2016-09-03T00:04:29Z,2016-09-03T00:04:29Z,MEMBER,"We have a bit of a circular imports mess :). For now, just import them at the top of the `to_netcdf` method.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,173632183
https://github.com/pydata/xarray/pull/990#issuecomment-244505054,https://api.github.com/repos/pydata/xarray/issues/990,244505054,MDEyOklzc3VlQ29tbWVudDI0NDUwNTA1NA==,1217238,2016-09-02T22:50:56Z,2016-09-02T22:50:56Z,MEMBER,"I have a couple inline comments that I think you missed?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,173632183
https://github.com/pydata/xarray/pull/990#issuecomment-244132923,https://api.github.com/repos/pydata/xarray/issues/990,244132923,MDEyOklzc3VlQ29tbWVudDI0NDEzMjkyMw==,1217238,2016-09-01T16:21:58Z,2016-09-01T16:21:58Z,MEMBER,"I have a few final nits, but looking very nice!
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,173632183
https://github.com/pydata/xarray/pull/990#issuecomment-243948268,https://api.github.com/repos/pydata/xarray/issues/990,243948268,MDEyOklzc3VlQ29tbWVudDI0Mzk0ODI2OA==,1217238,2016-09-01T01:10:56Z,2016-09-01T01:10:56Z,MEMBER,"The easiest fix would be to add a decorator to skip tests on Windows, like the existing decorators that we use:
https://github.com/pydata/xarray/blob/master/xarray/test/__init__.py#L73

I'm not sure off hand how to detect if we're running on Windows but it can't be hard.

To add a close method, I would copy these lines from `dataset.py` (or better use, move them to the common base class `BaseDataObject` in `common.py`):
https://github.com/pydata/xarray/blob/master/xarray/core/dataset.py#L251-L262

Then, you just need to define `_file_obj = None` in `DataArray.__init__` and set it when appropriate.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,173632183
https://github.com/pydata/xarray/pull/990#issuecomment-243007936,https://api.github.com/repos/pydata/xarray/issues/990,243007936,MDEyOklzc3VlQ29tbWVudDI0MzAwNzkzNg==,1217238,2016-08-29T00:00:46Z,2016-08-29T00:00:46Z,MEMBER,"I would add these tests to test_backends, probably a new test class. The
best test is probably a round-trip test where we save and load a DataArray
and verify that the result is identical to what we started with.
On Sun, Aug 28, 2016 at 2:20 PM Robin Wilson notifications@github.com
wrote:

> Thanks @shoyer https://github.com/shoyer - I wasn't actually aware that
> DataArrays can have a name _before_ they're put into a Dataset (that's
> one of the things I love about contributing to OSS: you always learn things
> about the software that you never knew before!). I'll deal with the design
> issues ASAP.
> 
> How would you suggest testing this? I wasn't sure where to put the tests,
> and what exactly to test? Presumably something about the equivalence
> between this and saving after manually converting to a dataset, but I
> wasn't really sure how best to go about it.
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> https://github.com/pydata/xarray/pull/990#issuecomment-243000159, or mute
> the thread
> https://github.com/notifications/unsubscribe-auth/ABKS1qbgrUqpkuRNqP4BjhclA25MrRN-ks5qkfusgaJpZM4Ju3Aq
> .
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,173632183
https://github.com/pydata/xarray/pull/990#issuecomment-242996578,https://api.github.com/repos/pydata/xarray/issues/990,242996578,MDEyOklzc3VlQ29tbWVudDI0Mjk5NjU3OA==,1217238,2016-08-28T20:15:21Z,2016-08-28T20:15:21Z,MEMBER,"I'm also a little concerned about the design here, because it always saves/restores the DataArray with the name `'data'`, which could override the original name. Ideally this method should save/restore a DataArray as faithfully as possible.

Instead, maybe we should only override the original name if it's `None`, or the same name as one of it's coordinates (which would otherwise result in an invalid NetCDF file).

Then we could restore by looking for a Dataset with single data variable regardless of the name, e.g.,

```
if len(dataset.data_vars) != 1:
    raise ValueError
data_array, = dataset.data_vars.values()
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,173632183
https://github.com/pydata/xarray/pull/990#issuecomment-242996279,https://api.github.com/repos/pydata/xarray/issues/990,242996279,MDEyOklzc3VlQ29tbWVudDI0Mjk5NjI3OQ==,1217238,2016-08-28T20:08:57Z,2016-08-28T20:08:57Z,MEMBER,"This is great, but it needs tests and documentation :).
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,173632183