html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/issues/974#issuecomment-362949749,https://api.github.com/repos/pydata/xarray/issues/974,362949749,MDEyOklzc3VlQ29tbWVudDM2Mjk0OTc0OQ==,1217238,2018-02-04T23:30:11Z,2018-02-04T23:30:11Z,MEMBER,"Vectorized indexing was implemented by https://github.com/pydata/xarray/pull/1473 I've opened a new issue #1887 for multi-dimensional boolean indexing.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,171828347 https://github.com/pydata/xarray/issues/974#issuecomment-313982206,https://api.github.com/repos/pydata/xarray/issues/974,313982206,MDEyOklzc3VlQ29tbWVudDMxMzk4MjIwNg==,1217238,2017-07-10T01:49:57Z,2017-07-10T02:01:58Z,MEMBER,I opened a pull request with your branch in #1473 so I can comment/view your changes. I hope that's OK!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,171828347 https://github.com/pydata/xarray/issues/974#issuecomment-313980675,https://api.github.com/repos/pydata/xarray/issues/974,313980675,MDEyOklzc3VlQ29tbWVudDMxMzk4MDY3NQ==,1217238,2017-07-10T01:34:23Z,2017-07-10T01:34:23Z,MEMBER,"@fujiisoup My first two bullets for boolean indexing are actually new functionality, so we wouldn't need that for a first pass here. It actually would probably be better to save it for a second PR. My third bullet on boolean indexing is basically just saying that `da[key_1, ..., key_n]` and `ds.sel(x=key)` should be handled in a consistent way with the new indexing behavior when given a boolean array. I don't think this will require any special adjustments -- it should fall out pretty immediately once you get the rest working.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,171828347 https://github.com/pydata/xarray/issues/974#issuecomment-313170506,https://api.github.com/repos/pydata/xarray/issues/974,313170506,MDEyOklzc3VlQ29tbWVudDMxMzE3MDUwNg==,1217238,2017-07-05T17:25:07Z,2017-07-05T17:25:20Z,MEMBER,"I haven't had the time to start working on this -- help would be very gratefully appreciated! In rough order, I would suggest: 0. Write a design doc for any new API. We basically have this here, but there may be a few aspects that still need to be thought through, so I would appreciate your critical review. 1. Write the test suite for the new functionality. We could even submit this, with the tests [marked as xfail](https://docs.pytest.org/en/latest/skipping.html). 2. Implement the core functionality and get the new tests to pass. This is the fun part :). 3. Get the existing test suite to pass. This will likely be the most painful part, because there will be a number of completely unrelated test failures. I can definitely help when we get to this stage.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,171828347