html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/7724#issuecomment-1504083577,https://api.github.com/repos/pydata/xarray/issues/7724,1504083577,IC_kwDOAMm_X85Zpn55,14808389,2023-04-11T21:00:05Z,2023-04-11T21:00:05Z,MEMBER,"no, `mypy` should be fine, as the CI version does not complain and I assume whatever the hook is reporting is also present on `main` (I didn't check, though).

As far as I can tell, the only thing left is another round of reviews.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1655782486
https://github.com/pydata/xarray/pull/7724#issuecomment-1501135058,https://api.github.com/repos/pydata/xarray/issues/7724,1501135058,IC_kwDOAMm_X85ZeYDS,14808389,2023-04-09T13:57:19Z,2023-04-09T13:57:19Z,MEMBER,"> I think we could check if the newest mypy still segfaults or not...

it didn't for me when I ran the hook, but that might just have been luck. To confirm, we'd need a PR that unpins `mypy` and potentially fixes all the errors that popped up since.

The `mypy` hook didn't take that long, but I guess it's the accumulated time that counts. Also, I learned today that the `black-jupyter` hook does all that `black` does *plus* format notebooks, so removing `id: black` should also shave off a bit.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1655782486
https://github.com/pydata/xarray/pull/7724#issuecomment-1500113295,https://api.github.com/repos/pydata/xarray/issues/7724,1500113295,IC_kwDOAMm_X85ZaemP,14808389,2023-04-07T09:25:49Z,2023-04-07T09:25:49Z,MEMBER,"@Illviljan, @headtr1ck, I just noticed that the CI version of `mypy` is pinned to `<0.990`, but the `pre-commit` hook is at `1.1.1`. Is that intentional / known? Running the hook also exposes quite a few typing errors.

Otherwise this should be ready for a final review, and the failing datetime-related tests will be fixed by #7731.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1655782486
https://github.com/pydata/xarray/pull/7724#issuecomment-1498929670,https://api.github.com/repos/pydata/xarray/issues/7724,1498929670,IC_kwDOAMm_X85ZV9oG,14808389,2023-04-06T11:40:12Z,2023-04-06T11:40:12Z,MEMBER,"It seems this fixes the failing tests unrelated to the `datetime64` range.

Regarding the failing doctests, I decided to cast the values of `arr.dt.<field>` to `int64` to keep the API unchanged. However, if we decide to follow `pandas` and return `int32` I'm happy to make that change.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1655782486