html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/7716#issuecomment-1510442337,https://api.github.com/repos/pydata/xarray/issues/7716,1510442337,IC_kwDOAMm_X85aB4Vh,14808389,2023-04-16T17:47:07Z,2023-04-16T17:51:39Z,MEMBER,"I'm on a train wifi, so not really better. However, I think this is because `xarray=2023.04.0` is not on `conda-forge`, yet (the PR to the feedstock still has to be merged), so you can't install `xarray` and `pandas=2` into the same environment. As a workaround, you can try installing `xarray` using `pip`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1510434058,https://api.github.com/repos/pydata/xarray/issues/7716,1510434058,IC_kwDOAMm_X85aB2UK,14808389,2023-04-16T17:08:16Z,2023-04-16T17:08:16Z,MEMBER,"can you share a bit more about the environment you're trying to create? Is that by chance a `py38` environment, or does one of the libraries you're trying to install have a upper bound for `xarray`? `xarray>=2023.04.0` does not have the pin on `pandas` anymore, so you should be able to install that even if the repodata patches didn't work.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1497664639,https://api.github.com/repos/pydata/xarray/issues/7716,1497664639,IC_kwDOAMm_X85ZRIx_,14808389,2023-04-05T15:16:12Z,2023-04-06T08:38:30Z,MEMBER,"CI says these are the tests we'd need to fix:
```
FAILED xarray/tests/test_coding_times.py::test_should_cftime_be_used_source_outside_range - Failed: DID NOT RAISE
FAILED xarray/tests/test_cftimeindex.py::test_to_datetimeindex_out_of_range[360_day] - Failed: DID NOT RAISE
FAILED xarray/tests/test_cftimeindex.py::test_to_datetimeindex_out_of_range[365_day] - Failed: DID NOT RAISE
FAILED xarray/tests/test_cftimeindex.py::test_to_datetimeindex_out_of_range[366_day] - Failed: DID NOT RAISE
FAILED xarray/tests/test_cftimeindex.py::test_to_datetimeindex_out_of_range[all_leap] - Failed: DID NOT RAISE
FAILED xarray/tests/test_cftimeindex.py::test_to_datetimeindex_out_of_range[gregorian] - Failed: DID NOT RAISE
FAILED xarray/tests/test_cftimeindex.py::test_to_datetimeindex_out_of_range[julian] - Failed: DID NOT RAISE
FAILED xarray/tests/test_cftimeindex.py::test_to_datetimeindex_out_of_range[noleap] - Failed: DID NOT RAISE
FAILED xarray/tests/test_cftimeindex.py::test_to_datetimeindex_out_of_range[proleptic_gregorian] - Failed: DID NOT RAISE
FAILED xarray/tests/test_cftimeindex.py::test_to_datetimeindex_out_of_range[standard] - Failed: DID NOT RAISE
FAILED xarray/tests/test_dataarray.py::TestDataArray::test_sel_float - NotImplementedError: float16 indexes are not supported
```
Edit: one more on windows:
```
FAILED xarray/tests/test_utils.py::test_maybe_coerce_to_str[1-2-expected1] - AssertionError: assert dtype('int64') == dtype('int32')
+ where dtype('int64') = Index([1, 2], dtype='int64').dtype
+ and dtype('int32') = Index([1, 2], dtype='int32').dtype
```
Edit2: the doctests also fail:
```
FAILED xarray/core/accessor_dt.py::xarray.core.accessor_dt.DatetimeAccessor
FAILED xarray/core/accessor_dt.py::xarray.core.accessor_dt.TimedeltaAccessor
FAILED xarray/core/dataarray.py::xarray.core.dataarray.DataArray.groupby
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1498186880,https://api.github.com/repos/pydata/xarray/issues/7716,1498186880,IC_kwDOAMm_X85ZTISA,14808389,2023-04-05T21:30:41Z,2023-04-05T21:35:25Z,MEMBER,"For `test_should_cftime_be_used_source_outside_range` and `test_to_datetimeindex_out_of_range` I'd probably use a date that is outside the `s` resolution range (not sure if that actually makes sense, though). What do you think, @spencerkclark?
For `test_maybe_coerce_to_str` I think the reason is that we use `np.array` to cast a python `int` to an array, but the default resolution is different on windows. Apparently, `pandas` still uses `int64` if constructed directly from python `int`s, but `numpy` uses `int32` on windows, and as you say `pandas` does not insist on `int64` anymore. The fix would be to explicitly specify the `dtype` in the `array` calls.
And finally, I'm not sure what to do with `test_sel_float`. Maybe we can split the monolithic test into one parametrized by `dtype` and skip the `float16` test variant for `pandas>=2.0`?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522
https://github.com/pydata/xarray/issues/7716#issuecomment-1497623839,https://api.github.com/repos/pydata/xarray/issues/7716,1497623839,IC_kwDOAMm_X85ZQ-0f,14808389,2023-04-05T14:51:16Z,2023-04-05T14:51:16Z,MEMBER,"with the merge of #7441 we should already support `pandas=2.0` on `main`. I think we can try unpinning in a PR to see how many of the errors from #7707 are related to `pandas` (none, hopefully, but I'm not sure).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1654022522