html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/7461#issuecomment-1402872179,https://api.github.com/repos/pydata/xarray/issues/7461,1402872179,IC_kwDOAMm_X85TniFz,2443309,2023-01-25T00:23:38Z,2023-01-25T00:23:38Z,MEMBER,"After thinking about this a bit more, I suggest we leave the numpy dtype issue for later. I'd rather not import the private dtypes (at least as part of this PR). So plan for going forward. @dcherian has already approved this PR. I think it would be good to get one more reviewer to double check things here. Then, assuming things are looking good, I'd like to merge. I will open an issue about the dtype import to track that separately. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1550109629 https://github.com/pydata/xarray/pull/7461#issuecomment-1402493257,https://api.github.com/repos/pydata/xarray/issues/7461,1402493257,IC_kwDOAMm_X85TmFlJ,2443309,2023-01-24T19:41:24Z,2023-01-24T19:41:24Z,MEMBER,"@Illviljan, @shoyer, or @keewis - do any of you have suggestions for how to respond to this comment? https://github.com/pydata/xarray/blob/b21f62ee37eea3650a58e9ffa3a7c9f4ae83006b/xarray/core/types.py#L57-L62 ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1550109629 https://github.com/pydata/xarray/pull/7461#issuecomment-1398677525,https://api.github.com/repos/pydata/xarray/issues/7461,1398677525,IC_kwDOAMm_X85TXiAV,2443309,2023-01-20T17:07:02Z,2023-01-20T20:51:26Z,MEMBER,"I'm doing a bit of an audit on our conditional version logic. A few questions that I don't know how to resolve on my own. - [ ] `_SupportsDType` - @headtr1ck, do you have a suggestion for how to handle this comment: https://github.com/pydata/xarray/blob/b21f62ee37eea3650a58e9ffa3a7c9f4ae83006b/xarray/core/types.py#L57-L62 - [x] `timedeltas` - @spencerkclark, do you have a suggestion for how to handle this comment: https://github.com/pydata/xarray/blob/b21f62ee37eea3650a58e9ffa3a7c9f4ae83006b/xarray/coding/times.py#L358-L363 - [x] `GenericAlias` - @Illviljan, do you have a suggestion for how to handle this comment: https://github.com/pydata/xarray/blob/b4e3cbcf17374b68477ed3ff7a8a52c82837ad91/xarray/core/coordinates.py#L31-L40","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1550109629 https://github.com/pydata/xarray/pull/7461#issuecomment-1398582379,https://api.github.com/repos/pydata/xarray/issues/7461,1398582379,IC_kwDOAMm_X85TXKxr,2443309,2023-01-20T15:46:50Z,2023-01-20T15:46:50Z,MEMBER,"@pydata/xarray - This PR is ready for discussion / review. Our minimum versions policy says its time to drop Python 3.8. But do we want to do that? I'll note that work is already underway to support Python 3.11 (#7316). ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1550109629