html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/7267#issuecomment-1346786560,https://api.github.com/repos/pydata/xarray/issues/7267,1346786560,IC_kwDOAMm_X85QRlUA,14808389,2022-12-12T15:59:33Z,2022-12-12T15:59:33Z,MEMBER,"the `mypy` failures look unrelated, so let's merge","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1440354343
https://github.com/pydata/xarray/pull/7267#issuecomment-1341655437,https://api.github.com/repos/pydata/xarray/issues/7267,1341655437,IC_kwDOAMm_X85P-AmN,2448579,2022-12-07T22:07:19Z,2022-12-07T22:07:19Z,MEMBER,@keewis shall we merge?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1440354343
https://github.com/pydata/xarray/pull/7267#issuecomment-1317514344,https://api.github.com/repos/pydata/xarray/issues/7267,1317514344,IC_kwDOAMm_X85Oh6xo,2448579,2022-11-16T18:53:16Z,2022-11-16T18:53:16Z,MEMBER,"> so I wonder if we should do this in one (slightly big) PR? But then we might need a deprecation cycle?
I think we decided to avoid the deprecation cycle for `keep_attrs` changes.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1440354343
https://github.com/pydata/xarray/pull/7267#issuecomment-1307873863,https://api.github.com/repos/pydata/xarray/issues/7267,1307873863,IC_kwDOAMm_X85N9JJH,14808389,2022-11-08T21:50:46Z,2022-11-08T21:50:46Z,MEMBER,"I'm always setting `xr.set_options(keep_attrs=True)` after importing `xarray`, anyways, so :+1: from me.
However, this would be a change in policy (#3891) so I wonder if we should do this in one (slightly big) PR? But then we might need a deprecation cycle?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1440354343
https://github.com/pydata/xarray/pull/7267#issuecomment-1307719581,https://api.github.com/repos/pydata/xarray/issues/7267,1307719581,IC_kwDOAMm_X85N8jed,5635139,2022-11-08T19:21:58Z,2022-11-08T19:21:58Z,MEMBER,"> LGTM. Could consider having it be True by default since _most_ attrs will still make sense.
+1 to both the specific point and generally moving in this direction...","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1440354343
https://github.com/pydata/xarray/pull/7267#issuecomment-1307417740,https://api.github.com/repos/pydata/xarray/issues/7267,1307417740,IC_kwDOAMm_X85N7ZyM,14808389,2022-11-08T15:39:46Z,2022-11-08T16:49:53Z,MEMBER,"wow, it seems now the `mypy` CI fails with a segfault. @headtr1ck, @Illviljan, @max-sixty: should we pin `mypy` to `mypy<0.990` until we (or rather: any of you?) can figure out what is going wrong with that?","{""total_count"": 3, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 1}",,1440354343