html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/7222#issuecomment-1295193308,https://api.github.com/repos/pydata/xarray/issues/7222,1295193308,IC_kwDOAMm_X85NMxTc,2448579,2022-10-28T16:22:24Z,2022-10-28T16:22:24Z,MEMBER,"```
       before           after         ratio
     [040816a6]       [cd40c8a0]
-         486±6μs          311±5μs     0.64  merge.DatasetAddVariable.time_variable_insertion(10)
-        19.1±2ms       12.0±0.2ms     0.63  merge.DatasetAddVariable.time_variable_insertion(1000)
-     2.18±0.02ms      1.34±0.03ms     0.62  merge.DatasetAddVariable.time_variable_insertion(100)
```

nice work @hmaarrfk !","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1423321834
https://github.com/pydata/xarray/pull/7222#issuecomment-1293624950,https://api.github.com/repos/pydata/xarray/issues/7222,1293624950,IC_kwDOAMm_X85NGyZ2,4160723,2022-10-27T14:37:10Z,2022-10-27T14:37:10Z,MEMBER,"Thanks @hmaarrfk!

> I think the rapid return, helps by about 40% is still pretty good.

Yes definitely. I think we just forgot to add it.

> However, I will argue that Aligner should really not be a class.

The reason of using a class is mainly for better code readability and also so that it is easier to refactor later. The alignment logic is really complex with lots of intermediate objects that are created and/or used at various stages. Probably using functions with some custom containers would have achieved the same goal, to be fair. This part of Xarray internals still deserves to be improved, but that would be a lot of work especially for such a critical piece of code in Xarray.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1423321834