html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/7209#issuecomment-1331208147,https://api.github.com/repos/pydata/xarray/issues/7209,1331208147,IC_kwDOAMm_X85PWJ_T,2448579,2022-11-29T19:51:28Z,2022-11-29T19:51:28Z,MEMBER,"I don't think we need a benchmark to merge. Sorry that wasn't clear, it mostly for information purposes. > The change in Variable.to_index_variable seems sensible (not sure when one wants a deep copy of an IndexVariable or an Xarray / Pandas index). Great! let's merge","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1421441672 https://github.com/pydata/xarray/pull/7209#issuecomment-1305593478,https://api.github.com/repos/pydata/xarray/issues/7209,1305593478,IC_kwDOAMm_X85N0caG,4160723,2022-11-07T13:09:05Z,2022-11-07T13:09:05Z,MEMBER,"The change in `Variable.to_index_variable` seems sensible (not sure when one wants a deep copy of an `IndexVariable` or an Xarray / Pandas index). `to_index_variable` may be called in some core functions of Xarray internals (e.g., in `as_variable()`) so it might be tricky to benchmark its effect Xarray-wise. Perhaps it would be good to track it down in the original issue #7181?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1421441672 https://github.com/pydata/xarray/pull/7209#issuecomment-1295199409,https://api.github.com/repos/pydata/xarray/issues/7209,1295199409,IC_kwDOAMm_X85NMyyx,2448579,2022-10-28T16:28:12Z,2022-10-28T16:28:12Z,MEMBER,"Thanks @headtr1ck do we have a benchmark for this, if not can we add one please?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1421441672