html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/7052#issuecomment-1279931075,https://api.github.com/repos/pydata/xarray/issues/7052,1279931075,IC_kwDOAMm_X85MSjLD,14371165,2022-10-16T09:27:18Z,2022-10-16T09:27:18Z,MEMBER,Thanks @headtr1ck ! :),"{""total_count"": 2, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 2, ""rocket"": 0, ""eyes"": 0}",,1377128403 https://github.com/pydata/xarray/pull/7052#issuecomment-1277951477,https://api.github.com/repos/pydata/xarray/issues/7052,1277951477,IC_kwDOAMm_X85MK_31,14371165,2022-10-13T17:31:49Z,2022-10-13T18:26:23Z,MEMBER,"Yeah, I had some strange issues there. One was that the branch wasn't up to date and another one that I can't replicate anymore... Sorry for the noise, Agreed on the labels, I haven't figured how to avoid that overlap yet. y should point to the top as it does in 2D plots, it makes it easy to orient yourself as you add dimensions: ```python ds = xr.tutorial.scatter_example_dataset(seed=42) fg = ds.plot.scatter(x=""A"", y=""B"", hue=""y"", row=""x"", col=""w"") fg = ds.plot.scatter(x=""A"", y=""B"", z=""z"", hue=""y"", row=""x"", col=""w"") ``` ![image](https://user-images.githubusercontent.com/14371165/195664682-1c5be769-9f61-4e58-8da3-bf96bfd74088.png) ![image](https://user-images.githubusercontent.com/14371165/195676806-e86945ca-8587-4d06-8b63-d0cfbc786493.png) Not how it's done in plots2d (yet) though.","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 1, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1377128403 https://github.com/pydata/xarray/pull/7052#issuecomment-1278007157,https://api.github.com/repos/pydata/xarray/issues/7052,1278007157,IC_kwDOAMm_X85MLNd1,14371165,2022-10-13T18:23:11Z,2022-10-13T18:23:11Z,MEMBER,"I use windows as well. :) I just had my plot in an interactive window that was maximized. I can get it too look as bad as yours as well: ![image](https://user-images.githubusercontent.com/14371165/195675583-294a74bd-501c-41c1-821a-a90be8edfaa0.png) ","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 1, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1377128403 https://github.com/pydata/xarray/pull/7052#issuecomment-1277853940,https://api.github.com/repos/pydata/xarray/issues/7052,1277853940,IC_kwDOAMm_X85MKoD0,14371165,2022-10-13T16:10:01Z,2022-10-13T17:27:46Z,MEMBER,edit,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1377128403 https://github.com/pydata/xarray/pull/7052#issuecomment-1277813315,https://api.github.com/repos/pydata/xarray/issues/7052,1277813315,IC_kwDOAMm_X85MKeJD,14371165,2022-10-13T15:38:14Z,2022-10-13T15:38:14Z,MEMBER,"> Anyway, you should use kwargs for x and y as well :) Hah, unfortunately my random test scripts I copy/pasted from can't keep up with branches. :D","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1377128403 https://github.com/pydata/xarray/pull/7052#issuecomment-1277793880,https://api.github.com/repos/pydata/xarray/issues/7052,1277793880,IC_kwDOAMm_X85MKZZY,14371165,2022-10-13T15:25:23Z,2022-10-13T15:25:23Z,MEMBER,"This crashes now. Maybe you'll find the bug faster than me. ```python import xarray as xr ds = xr.tutorial.scatter_example_dataset(seed=42) fg = ds.plot.scatter(""A"", ""B"", z=""z"", hue=""y"", row=""x"", col=""w"") Traceback (most recent call last): File ""C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\spyder_kernels\py3compat.py"", line 356, in compat_exec exec(code, globals, locals) File ""g:\program\dropbox\python\xarray_line_plot.py"", line 122, in fg = ds.plot.scatter(""A"", ""B"", z=""z"", hue=""y"", row=""x"", col=""w"") File ""C:\Users\J.W\Documents\GitHub\xarray\xarray\plot\accessor.py"", line 975, in scatter return dataset_plot.scatter(self._ds, *args, **kwargs) File ""C:\Users\J.W\Documents\GitHub\xarray\xarray\plot\dataset_plot.py"", line 234, in newplotfunc return _easy_facetgrid(kind=""dataset"", **allargs, **kwargs) File ""C:\Users\J.W\Documents\GitHub\xarray\xarray\plot\facetgrid.py"", line 770, in _easy_facetgrid return g.map_dataset(plotfunc, x, y, **kwargs) File ""C:\Users\J.W\Documents\GitHub\xarray\xarray\plot\facetgrid.py"", line 370, in map_dataset maybe_mappable = func( File ""C:\Users\J.W\Documents\GitHub\xarray\xarray\plot\dataset_plot.py"", line 262, in newplotfunc primitive = plotfunc( File ""C:\Users\J.W\Documents\GitHub\xarray\xarray\plot\dataset_plot.py"", line 541, in scatter primitive = ax.scatter( File ""C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\matplotlib\__init__.py"", line 1423, in inner return func(ax, *map(sanitize_sequence, args), **kwargs) File ""C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\matplotlib\axes\_axes.py"", line 4626, in scatter collection._internal_update(kwargs) File ""C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\matplotlib\artist.py"", line 1186, in _internal_update return self._update_props( File ""C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\matplotlib\artist.py"", line 1160, in _update_props raise AttributeError( AttributeError: PathCollection.set() got an unexpected keyword argument 'z' ``` ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1377128403 https://github.com/pydata/xarray/pull/7052#issuecomment-1271779030,https://api.github.com/repos/pydata/xarray/issues/7052,1271779030,IC_kwDOAMm_X85Lzc7W,14371165,2022-10-07T16:03:30Z,2022-10-07T16:03:30Z,MEMBER,I've merged the PR. :) Have fun with the conflicts!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1377128403 https://github.com/pydata/xarray/pull/7052#issuecomment-1257224879,https://api.github.com/repos/pydata/xarray/issues/7052,1257224879,IC_kwDOAMm_X85K77qv,14371165,2022-09-25T16:05:46Z,2022-09-25T16:05:46Z,MEMBER,I've merged the easy ones now. I'm not as confident on #6778 and could use another review on it.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1377128403 https://github.com/pydata/xarray/pull/7052#issuecomment-1257014146,https://api.github.com/repos/pydata/xarray/issues/7052,1257014146,IC_kwDOAMm_X85K7IOC,14371165,2022-09-24T16:52:16Z,2022-09-24T16:52:16Z,MEMBER,"Maybe there's something to learn from how pandas does it: https://github.com/pandas-dev/pandas/tree/main/pandas/plotting ? I'm a little skeptical if all the arguments in scatter are necessary and maybe they can be hidden in `kwargs`? Should make the overloads a little shorter. I've been working on moving all plots to the DataArray side starting with scatter in #6778. It should also remove the `list[PathCollection]` overloads.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1377128403