html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/6665#issuecomment-1154368202,https://api.github.com/repos/pydata/xarray/issues/6665,1154368202,IC_kwDOAMm_X85EzkLK,5635139,2022-06-13T19:54:41Z,2022-06-13T19:54:41Z,MEMBER,"Yes great, let's merge this.
> And then open another issue on how to procede with rename in light of the index refactor?
Great!
---
Then two main options I see for synthesizing the vars issues:
- `rename` operates on DataArray as described in https://github.com/pydata/xarray/pull/6665#issuecomment-1150810485. Generally I'm less keen on ""different types have different semantics"", and here a positional arg would mean a DataArray rename, and kwarg would mean var rename. But it does work locally to DataArray quite well.
- `rename` only exists on DataArrays for the name of the DataArray, and we use `rename_vars` & `rename_dims` for both DataArrays & Datasets. So `Dataset.rename` is soft-deprecated.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1261153511
https://github.com/pydata/xarray/pull/6665#issuecomment-1152977928,https://api.github.com/repos/pydata/xarray/issues/6665,1152977928,IC_kwDOAMm_X85EuQwI,5635139,2022-06-11T18:32:14Z,2022-06-11T18:32:14Z,MEMBER,"@keewis v interesting suggestion — the object name as positional and vars as kwargs.
As I think was mentioned above, one choice is whether a kwarg with the name of the object renames the object. I would worry it's slightly ambiguous. And potentially not additive. WDYT?
> a `rename_dims` method
This could be good. Would this also rename the coord associated with the dim?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1261153511
https://github.com/pydata/xarray/pull/6665#issuecomment-1150582510,https://api.github.com/repos/pydata/xarray/issues/6665,1150582510,IC_kwDOAMm_X85ElH7u,5635139,2022-06-09T01:45:57Z,2022-06-09T01:46:07Z,MEMBER,"> in `pint-xarray` we have the `.pint.to` method which uses a very similar concept, maybe it is worth copying that for `rename`?
We do want it to be fluent though, so it can be directly on the `DataArray`, otherwise you can't do:
```python
(
da
.rename(...)
.sum(...)
)
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1261153511
https://github.com/pydata/xarray/pull/6665#issuecomment-1150438146,https://api.github.com/repos/pydata/xarray/issues/6665,1150438146,IC_kwDOAMm_X85EkksC,5635139,2022-06-08T21:35:33Z,2022-06-08T21:35:33Z,MEMBER,"This seems like a nice improvement given the existing state.
I've found the effort to specialize methods (e.g. `drop_var` vs. `drop_sel`) has been good, and we might want to extend this principle. With the proposed code:
- renaming a coord on a `DataArray` is `rename`
- renaming a coord on a `Dataset` is `rename_vars`
...which is not ideal, though might be the best tradeoff.
WDYT @headtr1ck ? Or any other thoughts from others?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1261153511