html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/issues/6345#issuecomment-1065385198,https://api.github.com/repos/pydata/xarray/issues/6345,1065385198,IC_kwDOAMm_X84_gHzu,1197350,2022-03-11T18:41:11Z,2022-03-11T18:41:11Z,MEMBER,It seems like what we really want to do is verify that the datatype of the appended data matches the data type on disk.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1164454058 https://github.com/pydata/xarray/issues/6345#issuecomment-1065381346,https://api.github.com/repos/pydata/xarray/issues/6345,1065381346,IC_kwDOAMm_X84_gG3i,1217238,2022-03-11T18:38:42Z,2022-03-11T18:38:42Z,MEMBER,"The data type restriction here seems to date back to the original PR adding support for appending. I turned up this comment that seems to summarize the motivation for this check: https://github.com/pydata/xarray/pull/2706#issuecomment-502481584 I think the original issue was that appending a fixed-width string could be a problem if the fixed-width does not match the width of the existing string dtype stored in Zarr. This obviously doesn't apply in this case, because you are adding an entirely new variable. So I guess the check could be removed in that case.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1164454058 https://github.com/pydata/xarray/issues/6345#issuecomment-1065350469,https://api.github.com/repos/pydata/xarray/issues/6345,1065350469,IC_kwDOAMm_X84_f_VF,1197350,2022-03-11T17:58:28Z,2022-03-11T17:58:28Z,MEMBER,Thanks for reporting this @kmsampson. My feeling is that it is a bug...which we can hopefully fix pretty easily!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1164454058 https://github.com/pydata/xarray/issues/6345#issuecomment-1063401936,https://api.github.com/repos/pydata/xarray/issues/6345,1063401936,IC_kwDOAMm_X84_YjnQ,1197350,2022-03-09T21:43:49Z,2022-03-09T21:43:49Z,MEMBER,"The relevant code is here https://github.com/pydata/xarray/blob/d293f50f9590251ce09543319d1f0dc760466f1b/xarray/backends/api.py#L1405-L1406 and here https://github.com/pydata/xarray/blob/d293f50f9590251ce09543319d1f0dc760466f1b/xarray/backends/api.py#L1280-L1298 What I don't understand is _why different validation is needed for the append scenario than for the the write scenario_. @shoyer worked on this in #5252, so maybe he has some ideas.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1164454058