html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/538#issuecomment-136801819,https://api.github.com/repos/pydata/xarray/issues/538,136801819,MDEyOklzc3VlQ29tbWVudDEzNjgwMTgxOQ==,1217238,2015-09-01T17:20:52Z,2015-09-01T17:20:52Z,MEMBER,"OK, this seems like a clear improvement so I'm going to merge. Thanks again for all your work here! ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623 https://github.com/pydata/xarray/pull/538#issuecomment-136519747,https://api.github.com/repos/pydata/xarray/issues/538,136519747,MDEyOklzc3VlQ29tbWVudDEzNjUxOTc0Nw==,1217238,2015-08-31T22:40:55Z,2015-08-31T22:40:55Z,MEMBER,"@jhamman is the original designer of this API so perhaps he can clarify :). One possibly cleaner alternative is to have a separate `palette` argument for specifying Seaborn color palettes, rather than reusing `cmap` or trying to put it in `colors`. That would eliminate some ambiguity. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623 https://github.com/pydata/xarray/pull/538#issuecomment-136250265,https://api.github.com/repos/pydata/xarray/issues/538,136250265,MDEyOklzc3VlQ29tbWVudDEzNjI1MDI2NQ==,1217238,2015-08-31T04:38:36Z,2015-08-31T04:38:36Z,MEMBER,"@rabernat indeed, your willingness to dive in here is highly appreciated! I think this is pretty close -- are there aspects that you're still unsure about? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623 https://github.com/pydata/xarray/pull/538#issuecomment-136222754,https://api.github.com/repos/pydata/xarray/issues/538,136222754,MDEyOklzc3VlQ29tbWVudDEzNjIyMjc1NA==,1217238,2015-08-31T00:34:04Z,2015-08-31T00:34:04Z,MEMBER,"I think this will be the first PR merged for v0.6.1. Could you add a brief note to the what's new documentation under a section for ""API changes""? You'll need to create a new section for v0.6.1. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623 https://github.com/pydata/xarray/pull/538#issuecomment-135140425,https://api.github.com/repos/pydata/xarray/issues/538,135140425,MDEyOklzc3VlQ29tbWVudDEzNTE0MDQyNQ==,1217238,2015-08-26T19:01:31Z,2015-08-26T19:01:31Z,MEMBER,"Looks like you have commits from a few other changes (e.g., the 0.6 release) in this PR. Could you do a `rebase -i` to fix that? e.g., see the discussion here: https://github.com/pydata/pandas/pull/9826#issuecomment-132637777 ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623 https://github.com/pydata/xarray/pull/538#issuecomment-134268144,https://api.github.com/repos/pydata/xarray/issues/538,134268144,MDEyOklzc3VlQ29tbWVudDEzNDI2ODE0NA==,1217238,2015-08-24T16:07:15Z,2015-08-24T16:38:25Z,MEMBER,"We can do this as an interim fix, but I would prefer something more comprehensive: - add `colors` to the function/method signature for 2d plots - require `colors` when specifying a list of colors manually - `colors` is mutually exclusive with `cmap` - `colors` is only valid when levels is supplied or the plot is of type `contour` or `contourf` - deprecate supplying a list of colors with `cmap` (update the docs, issue a warning when this is done, eventually remove it entirely) ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623 https://github.com/pydata/xarray/pull/538#issuecomment-132328908,https://api.github.com/repos/pydata/xarray/issues/538,132328908,MDEyOklzc3VlQ29tbWVudDEzMjMyODkwOA==,1217238,2015-08-18T19:40:34Z,2015-08-18T19:40:34Z,MEMBER,"It would be very useful to have a test here to verify that the colors argument does the right thing. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623