html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/538#issuecomment-136552408,https://api.github.com/repos/pydata/xarray/issues/538,136552408,MDEyOklzc3VlQ29tbWVudDEzNjU1MjQwOA==,1197350,2015-09-01T02:10:51Z,2015-09-01T02:10:51Z,MEMBER,"@jhamman One nice thing about this current PR is that it does allow people _without_ seaborn to still use a custom list of colors. If we don't want to make seaborn a dependency, then surely that is a good thing. The only thing seaborn is now _needed_ for is its special named palettes. 

As for the named palettes, I don't think a new keyword is needed. `cmap` does what one would expect.

This has been a good learning experience for me. (Had never touched seaborn before.) But I probably won't work on this PR any more. Bottom line, it does fix the original issue without breaking anything. It also improves the testing of colors.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-136251570,https://api.github.com/repos/pydata/xarray/issues/538,136251570,MDEyOklzc3VlQ29tbWVudDEzNjI1MTU3MA==,1197350,2015-08-31T04:53:32Z,2015-08-31T04:53:32Z,MEMBER,"@shoyer There is still some redundancy between the `colors` and `cmap` keywords. I know what I would use these for, but I am still unsure how the original designer of the plotting api imagined these would work. My original problem was simply that I couldn't use `colors` the way I would in matplotplot.

I am also a little unsure about how seaborn fits into the plotting module. It is not a dependency, but certain parts of plotting are built around it. This leads to the need for lots of special cases and some ugly code.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-136249378,https://api.github.com/repos/pydata/xarray/issues/538,136249378,MDEyOklzc3VlQ29tbWVudDEzNjI0OTM3OA==,1197350,2015-08-31T04:31:04Z,2015-08-31T04:31:04Z,MEMBER,"This is turning into a real rabbit hole...
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-136219777,https://api.github.com/repos/pydata/xarray/issues/538,136219777,MDEyOklzc3VlQ29tbWVudDEzNjIxOTc3Nw==,1197350,2015-08-31T00:09:32Z,2015-08-31T00:09:32Z,MEMBER,"I think this latest commit solves everything.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-135506596,https://api.github.com/repos/pydata/xarray/issues/538,135506596,MDEyOklzc3VlQ29tbWVudDEzNTUwNjU5Ng==,1197350,2015-08-27T17:54:58Z,2015-08-27T17:55:33Z,MEMBER,"@jhamman is that question for me? I would say obviously not.

However, I think this dependency was already present even before this PR. There just wasn't a test that exposed it. If you passed a list of colors to cmap, I'm pretty sure you would get an error if seaborn was not installed. (Please correct me if I'm wrong.) 
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-135152416,https://api.github.com/repos/pydata/xarray/issues/538,135152416,MDEyOklzc3VlQ29tbWVudDEzNTE1MjQxNg==,1197350,2015-08-26T19:53:19Z,2015-08-26T19:53:19Z,MEMBER,"The testing errors I think are due to seaborn not being present.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-135148087,https://api.github.com/repos/pydata/xarray/issues/538,135148087,MDEyOklzc3VlQ29tbWVudDEzNTE0ODA4Nw==,1197350,2015-08-26T19:35:32Z,2015-08-26T19:35:32Z,MEMBER,"Ok, I think I fixed it. Just had to do a `git push --force`. Sorry for being such a git n00b. But honestly sometimes it is so confusing.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-135144970,https://api.github.com/repos/pydata/xarray/issues/538,135144970,MDEyOklzc3VlQ29tbWVudDEzNTE0NDk3MA==,1197350,2015-08-26T19:21:00Z,2015-08-26T19:21:00Z,MEMBER,"Sorry...I'm an idiot, and I always somehow manage to screw up these pull requests.

I did what you / that thread suggested

```
git fetch upstream master
git rebase -i upstream/master
```

When I try to push my PR again with `git push origin fix_contour_color` I get these errors

```
$ git push origin fix_contour_color 
To git@github.com:rabernat/xray.git
 ! [rejected]        fix_contour_color -> fix_contour_color (non-fast-forward)
error: failed to push some refs to 'git@github.com:rabernat/xray.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Merge the remote changes (e.g. 'git pull')
hint: before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-135050353,https://api.github.com/repos/pydata/xarray/issues/538,135050353,MDEyOklzc3VlQ29tbWVudDEzNTA1MDM1Mw==,1197350,2015-08-26T14:59:29Z,2015-08-26T14:59:29Z,MEMBER,"This update mostly implements @shoyer's plan. However, it currently only works if seaborn is installed. This is because it completely bypasses matplotlibs `colors` keyword and directly sets the colors in the internal functions (e.g. `_color_palette`). It relies on seaborn's `color_palette` function to turn the color list into a palette. I can't see an obvious way around this. Maybe someone has a suggestion.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-134429396,https://api.github.com/repos/pydata/xarray/issues/538,134429396,MDEyOklzc3VlQ29tbWVudDEzNDQyOTM5Ng==,1197350,2015-08-25T00:54:33Z,2015-08-25T00:54:33Z,MEMBER,"I can probably get to this within a few days. I would enjoy learning more about the plotting code.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-134219965,https://api.github.com/repos/pydata/xarray/issues/538,134219965,MDEyOklzc3VlQ29tbWVudDEzNDIxOTk2NQ==,1197350,2015-08-24T14:14:48Z,2015-08-24T14:14:48Z,MEMBER,"So what is the conclusion about this PR? I am happy to keep tweaking it if we can converge on the desired behavior...
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623