html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/538#issuecomment-136810234,https://api.github.com/repos/pydata/xarray/issues/538,136810234,MDEyOklzc3VlQ29tbWVudDEzNjgxMDIzNA==,2443309,2015-09-01T17:48:12Z,2015-09-01T17:48:12Z,MEMBER,"Thanks @rabernat .  
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-136801819,https://api.github.com/repos/pydata/xarray/issues/538,136801819,MDEyOklzc3VlQ29tbWVudDEzNjgwMTgxOQ==,1217238,2015-09-01T17:20:52Z,2015-09-01T17:20:52Z,MEMBER,"OK, this seems like a clear improvement so I'm going to merge. Thanks again for all your work here!
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-136552408,https://api.github.com/repos/pydata/xarray/issues/538,136552408,MDEyOklzc3VlQ29tbWVudDEzNjU1MjQwOA==,1197350,2015-09-01T02:10:51Z,2015-09-01T02:10:51Z,MEMBER,"@jhamman One nice thing about this current PR is that it does allow people _without_ seaborn to still use a custom list of colors. If we don't want to make seaborn a dependency, then surely that is a good thing. The only thing seaborn is now _needed_ for is its special named palettes. 

As for the named palettes, I don't think a new keyword is needed. `cmap` does what one would expect.

This has been a good learning experience for me. (Had never touched seaborn before.) But I probably won't work on this PR any more. Bottom line, it does fix the original issue without breaking anything. It also improves the testing of colors.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-136521381,https://api.github.com/repos/pydata/xarray/issues/538,136521381,MDEyOklzc3VlQ29tbWVudDEzNjUyMTM4MQ==,2443309,2015-08-31T22:52:49Z,2015-08-31T22:52:49Z,MEMBER,"@rabernat and @shoyer -

Sorry I've been mostly absent in this conversation recently.  I'm currently buried under a mound of C and Fortran code.

I included the optional seaborn call in the discrete colormap/colorbar PR to expose a few nice features in the seaborn color_palette api.  Namely, I wanted access to all the seaborn named color palettes and to be able to pass a list of custom colors.

I would be okay with adding the `palette` argument but it seems a bit excessive since `palette`, `cmap`, and `colors` are all basically orthogonal.  We don't have to stick to the matplotlib or seaborn api.  I understand the hesitation to overload any one of these parameters.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-136519747,https://api.github.com/repos/pydata/xarray/issues/538,136519747,MDEyOklzc3VlQ29tbWVudDEzNjUxOTc0Nw==,1217238,2015-08-31T22:40:55Z,2015-08-31T22:40:55Z,MEMBER,"@jhamman is the original designer of this API so perhaps he can clarify :).

One possibly cleaner alternative is to have a separate `palette` argument for specifying Seaborn color palettes, rather than reusing `cmap` or trying to put it in `colors`. That would eliminate some ambiguity.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-136251570,https://api.github.com/repos/pydata/xarray/issues/538,136251570,MDEyOklzc3VlQ29tbWVudDEzNjI1MTU3MA==,1197350,2015-08-31T04:53:32Z,2015-08-31T04:53:32Z,MEMBER,"@shoyer There is still some redundancy between the `colors` and `cmap` keywords. I know what I would use these for, but I am still unsure how the original designer of the plotting api imagined these would work. My original problem was simply that I couldn't use `colors` the way I would in matplotplot.

I am also a little unsure about how seaborn fits into the plotting module. It is not a dependency, but certain parts of plotting are built around it. This leads to the need for lots of special cases and some ugly code.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-136250265,https://api.github.com/repos/pydata/xarray/issues/538,136250265,MDEyOklzc3VlQ29tbWVudDEzNjI1MDI2NQ==,1217238,2015-08-31T04:38:36Z,2015-08-31T04:38:36Z,MEMBER,"@rabernat indeed, your willingness to dive in here is highly appreciated! I think this is pretty close -- are there aspects that you're still unsure about?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-136249378,https://api.github.com/repos/pydata/xarray/issues/538,136249378,MDEyOklzc3VlQ29tbWVudDEzNjI0OTM3OA==,1197350,2015-08-31T04:31:04Z,2015-08-31T04:31:04Z,MEMBER,"This is turning into a real rabbit hole...
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-136222754,https://api.github.com/repos/pydata/xarray/issues/538,136222754,MDEyOklzc3VlQ29tbWVudDEzNjIyMjc1NA==,1217238,2015-08-31T00:34:04Z,2015-08-31T00:34:04Z,MEMBER,"I think this will be the first PR merged for v0.6.1. Could you add a brief note to the what's new documentation under a section for ""API changes""? You'll need to create a new section for v0.6.1.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-136219777,https://api.github.com/repos/pydata/xarray/issues/538,136219777,MDEyOklzc3VlQ29tbWVudDEzNjIxOTc3Nw==,1197350,2015-08-31T00:09:32Z,2015-08-31T00:09:32Z,MEMBER,"I think this latest commit solves everything.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-135587730,https://api.github.com/repos/pydata/xarray/issues/538,135587730,MDEyOklzc3VlQ29tbWVudDEzNTU4NzczMA==,5356122,2015-08-27T23:59:33Z,2015-08-27T23:59:33Z,MEMBER,"@rabernat We were all Git noobs at some point- don't worry about it!

Seaborn should not be a dependency. 
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-135514411,https://api.github.com/repos/pydata/xarray/issues/538,135514411,MDEyOklzc3VlQ29tbWVudDEzNTUxNDQxMQ==,2443309,2015-08-27T18:26:16Z,2015-08-27T18:26:16Z,MEMBER,"You are correct.  We should create a colormap if seaborn is not installed.  The relevant line is here: https://github.com/rabernat/xray/blob/fix_contour_color/xray/plot/plot.py#L300

where we could add something like this sudo code:

``` python
if isinstance(cmap, list-like-thing):
    cmap = _cmap_from_list_of_colors(cmap)
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-135506596,https://api.github.com/repos/pydata/xarray/issues/538,135506596,MDEyOklzc3VlQ29tbWVudDEzNTUwNjU5Ng==,1197350,2015-08-27T17:54:58Z,2015-08-27T17:55:33Z,MEMBER,"@jhamman is that question for me? I would say obviously not.

However, I think this dependency was already present even before this PR. There just wasn't a test that exposed it. If you passed a list of colors to cmap, I'm pretty sure you would get an error if seaborn was not installed. (Please correct me if I'm wrong.) 
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-135196387,https://api.github.com/repos/pydata/xarray/issues/538,135196387,MDEyOklzc3VlQ29tbWVudDEzNTE5NjM4Nw==,2443309,2015-08-26T22:31:47Z,2015-08-26T22:31:47Z,MEMBER,"Do we want to make `seaborn` a mandatory dependency for plotting?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-135152416,https://api.github.com/repos/pydata/xarray/issues/538,135152416,MDEyOklzc3VlQ29tbWVudDEzNTE1MjQxNg==,1197350,2015-08-26T19:53:19Z,2015-08-26T19:53:19Z,MEMBER,"The testing errors I think are due to seaborn not being present.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-135148087,https://api.github.com/repos/pydata/xarray/issues/538,135148087,MDEyOklzc3VlQ29tbWVudDEzNTE0ODA4Nw==,1197350,2015-08-26T19:35:32Z,2015-08-26T19:35:32Z,MEMBER,"Ok, I think I fixed it. Just had to do a `git push --force`. Sorry for being such a git n00b. But honestly sometimes it is so confusing.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-135144970,https://api.github.com/repos/pydata/xarray/issues/538,135144970,MDEyOklzc3VlQ29tbWVudDEzNTE0NDk3MA==,1197350,2015-08-26T19:21:00Z,2015-08-26T19:21:00Z,MEMBER,"Sorry...I'm an idiot, and I always somehow manage to screw up these pull requests.

I did what you / that thread suggested

```
git fetch upstream master
git rebase -i upstream/master
```

When I try to push my PR again with `git push origin fix_contour_color` I get these errors

```
$ git push origin fix_contour_color 
To git@github.com:rabernat/xray.git
 ! [rejected]        fix_contour_color -> fix_contour_color (non-fast-forward)
error: failed to push some refs to 'git@github.com:rabernat/xray.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Merge the remote changes (e.g. 'git pull')
hint: before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-135140425,https://api.github.com/repos/pydata/xarray/issues/538,135140425,MDEyOklzc3VlQ29tbWVudDEzNTE0MDQyNQ==,1217238,2015-08-26T19:01:31Z,2015-08-26T19:01:31Z,MEMBER,"Looks like you have commits from a few other changes  (e.g., the 0.6 release) in this PR. Could you do a `rebase -i` to fix that? e.g., see the discussion here:
https://github.com/pydata/pandas/pull/9826#issuecomment-132637777
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-135050353,https://api.github.com/repos/pydata/xarray/issues/538,135050353,MDEyOklzc3VlQ29tbWVudDEzNTA1MDM1Mw==,1197350,2015-08-26T14:59:29Z,2015-08-26T14:59:29Z,MEMBER,"This update mostly implements @shoyer's plan. However, it currently only works if seaborn is installed. This is because it completely bypasses matplotlibs `colors` keyword and directly sets the colors in the internal functions (e.g. `_color_palette`). It relies on seaborn's `color_palette` function to turn the color list into a palette. I can't see an obvious way around this. Maybe someone has a suggestion.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-134429396,https://api.github.com/repos/pydata/xarray/issues/538,134429396,MDEyOklzc3VlQ29tbWVudDEzNDQyOTM5Ng==,1197350,2015-08-25T00:54:33Z,2015-08-25T00:54:33Z,MEMBER,"I can probably get to this within a few days. I would enjoy learning more about the plotting code.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-134268144,https://api.github.com/repos/pydata/xarray/issues/538,134268144,MDEyOklzc3VlQ29tbWVudDEzNDI2ODE0NA==,1217238,2015-08-24T16:07:15Z,2015-08-24T16:38:25Z,MEMBER,"We can do this as an interim fix, but I would prefer something more comprehensive:
- add `colors` to the function/method signature for 2d plots
- require `colors` when specifying a list of colors manually
- `colors` is mutually exclusive with `cmap`
- `colors` is only valid when levels is supplied or the plot is of type `contour` or `contourf`
- deprecate supplying a list of colors with `cmap` (update the docs, issue a warning when this is done, eventually remove it entirely)
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-134281471,https://api.github.com/repos/pydata/xarray/issues/538,134281471,MDEyOklzc3VlQ29tbWVudDEzNDI4MTQ3MQ==,5356122,2015-08-24T16:19:57Z,2015-08-24T16:19:57Z,MEMBER,"@shoyer has laid out a nice plan.

@rabernat do you feel like taking this on now? If not we can merge this and implement the rest later.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-134257862,https://api.github.com/repos/pydata/xarray/issues/538,134257862,MDEyOklzc3VlQ29tbWVudDEzNDI1Nzg2Mg==,2443309,2015-08-24T15:50:48Z,2015-08-24T15:50:48Z,MEMBER,"I have no problems with this.  @clarkfitzg - any more thoughts?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-134219965,https://api.github.com/repos/pydata/xarray/issues/538,134219965,MDEyOklzc3VlQ29tbWVudDEzNDIxOTk2NQ==,1197350,2015-08-24T14:14:48Z,2015-08-24T14:14:48Z,MEMBER,"So what is the conclusion about this PR? I am happy to keep tweaking it if we can converge on the desired behavior...
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623
https://github.com/pydata/xarray/pull/538#issuecomment-132328908,https://api.github.com/repos/pydata/xarray/issues/538,132328908,MDEyOklzc3VlQ29tbWVudDEzMjMyODkwOA==,1217238,2015-08-18T19:40:34Z,2015-08-18T19:40:34Z,MEMBER,"It would be very useful to have a test here to verify that the colors argument does the right thing.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,101719623