html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/2517#issuecomment-436062784,https://api.github.com/repos/pydata/xarray/issues/2517,436062784,MDEyOklzc3VlQ29tbWVudDQzNjA2Mjc4NA==,6153603,2018-11-05T22:40:46Z,2018-11-05T22:40:46Z,CONTRIBUTOR,"I think #2298 is what I'm really waiting for and would solve the use cases I listed above. I'll have no trouble using the accessor methods in the time being.
Thanks, @shoyer","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,374460958
https://github.com/pydata/xarray/issues/2517#issuecomment-434857661,https://api.github.com/repos/pydata/xarray/issues/2517,434857661,MDEyOklzc3VlQ29tbWVudDQzNDg1NzY2MQ==,6153603,2018-10-31T21:40:46Z,2018-10-31T21:40:46Z,CONTRIBUTOR,"The only problem I see with this is that `actual.acc.altitude` must be called before `actual.altitude`, otherwise it will result in the data_var being used before it is created.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,374460958
https://github.com/pydata/xarray/issues/2518#issuecomment-433624081,https://api.github.com/repos/pydata/xarray/issues/2518,433624081,MDEyOklzc3VlQ29tbWVudDQzMzYyNDA4MQ==,6153603,2018-10-27T14:14:39Z,2018-10-27T14:14:39Z,CONTRIBUTOR,Thanks for this @shoyer.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,374473176
https://github.com/pydata/xarray/issues/2284#issuecomment-404641052,https://api.github.com/repos/pydata/xarray/issues/2284,404641052,MDEyOklzc3VlQ29tbWVudDQwNDY0MTA1Mg==,6153603,2018-07-12T20:31:37Z,2018-07-12T20:31:37Z,CONTRIBUTOR,"Thanks, I will gladly exercise patience until then.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,340757861
https://github.com/pydata/xarray/issues/1821#issuecomment-365352132,https://api.github.com/repos/pydata/xarray/issues/1821,365352132,MDEyOklzc3VlQ29tbWVudDM2NTM1MjEzMg==,6153603,2018-02-13T18:05:06Z,2018-02-13T18:05:06Z,CONTRIBUTOR,"#1865 
It's a simple fix, but it affects my ability to produce CF1.7 netCDF files for distribution of our satellite data. The pull request #1869 is ready to go.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,287852184
https://github.com/pydata/xarray/pull/1869#issuecomment-364993025,https://api.github.com/repos/pydata/xarray/issues/1869,364993025,MDEyOklzc3VlQ29tbWVudDM2NDk5MzAyNQ==,6153603,2018-02-12T17:12:23Z,2018-02-12T17:12:23Z,CONTRIBUTOR,"@shoyer, I think everything is in order to apply this bug fix.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,292653302
https://github.com/pydata/xarray/pull/1869#issuecomment-362092065,https://api.github.com/repos/pydata/xarray/issues/1869,362092065,MDEyOklzc3VlQ29tbWVudDM2MjA5MjA2NQ==,6153603,2018-01-31T22:26:29Z,2018-01-31T22:26:29Z,CONTRIBUTOR,"@shoyer, do you have an opinion on whether or not to include the scipy fix or leave it out of this PR?
Also what is your opinion on the documentation? I feel nothing is needed as with this PR the code will operate as the documentation states.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,292653302
https://github.com/pydata/xarray/pull/1869#issuecomment-361766665,https://api.github.com/repos/pydata/xarray/issues/1869,361766665,MDEyOklzc3VlQ29tbWVudDM2MTc2NjY2NQ==,6153603,2018-01-30T23:11:57Z,2018-01-30T23:48:44Z,CONTRIBUTOR,"Now the tests pass (see comment beside the checkbox)

Honestly, I'm not happy with where I put the fix in order to get the tests to pass when using the scipy backend by adding an additional test, but I didn't know where else to put the test. The test to see if the variable would be checked in prepare_variables came before the encoding could be managed in encode_cf_variable in conventions.py

The alternative would be to remove the changes to scipy_.py and just have the test run only for the other engine backends and leave fixing the scipy backend for someone more familiar with it for another issue.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,292653302
https://github.com/pydata/xarray/pull/1869#issuecomment-361736359,https://api.github.com/repos/pydata/xarray/issues/1869,361736359,MDEyOklzc3VlQ29tbWVudDM2MTczNjM1OQ==,6153603,2018-01-30T21:14:52Z,2018-01-30T21:14:52Z,CONTRIBUTOR,Wait to merge... I'm still getting failed tests using the scipy backend,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,292653302
https://github.com/pydata/xarray/pull/1869#issuecomment-361734459,https://api.github.com/repos/pydata/xarray/issues/1869,361734459,MDEyOklzc3VlQ29tbWVudDM2MTczNDQ1OQ==,6153603,2018-01-30T21:07:36Z,2018-01-30T21:07:36Z,CONTRIBUTOR,"Unit tests added in 9210dfa45428842c69b8d1835013159b1230c572. The first and the third added tests use the encoding kwarg and fail without b8fd86d5614d28254406d6f9b6d4e37383efc1be applied and pass with b8fd86d5614d28254406d6f9b6d4e37383efc1be applied, so they should catch a regression.

The second added test passes both before and after b8fd86d5614d28254406d6f9b6d4e37383efc1be and was added for completeness as it pairs with the original test_explicitly_omit_fill_value, but for a coordinate.

I still think nothing needs to change in the documentation as this now follows the intent of the design.

I will leave it to you @shoyer or your delegate to address whether anything needs to be stated in the changelog / what's new.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,292653302
https://github.com/pydata/xarray/issues/1865#issuecomment-361473220,https://api.github.com/repos/pydata/xarray/issues/1865,361473220,MDEyOklzc3VlQ29tbWVudDM2MTQ3MzIyMA==,6153603,2018-01-30T04:23:26Z,2018-01-30T04:23:26Z,CONTRIBUTOR,"@shoyer, I'll look at the documentation once this is resolved and make a PR.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,292585285
https://github.com/pydata/xarray/issues/1865#issuecomment-361473052,https://api.github.com/repos/pydata/xarray/issues/1865,361473052,MDEyOklzc3VlQ29tbWVudDM2MTQ3MzA1Mg==,6153603,2018-01-30T04:22:19Z,2018-01-30T04:22:19Z,CONTRIBUTOR,"My apologies for having to re-open the issue, I should have tried the fix before closing.

I get the following error after changing my last line to: `ds.to_netcdf('/tmp/test.nc', encoding={'lat': {'_FillValue': None}, 'lon': {'_FillValue': None}})` as suggested.

```
  File ""/path/to/python3.6/site-packages/xarray/backends/netCDF4_.py"", line 354, in prepare_variable
    unlimited_dims=unlimited_dims)
  File ""/path/to/python3.6/site-packages/xarray/backends/netCDF4_.py"", line 176, in _extract_nc4_variable_encoding
    ' %r' % (backend, invalid))
ValueError: unexpected encoding parameters for 'netCDF4' backend:  ['_FillValue']
```
Do we just need to append '_FillValue' to the list of
````
     valid_encodings = set(['zlib', 'complevel', 'fletcher32', 'contiguous',
                           'chunksizes', 'shuffle'])
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,292585285
https://github.com/pydata/xarray/issues/1865#issuecomment-361470288,https://api.github.com/repos/pydata/xarray/issues/1865,361470288,MDEyOklzc3VlQ29tbWVudDM2MTQ3MDI4OA==,6153603,2018-01-30T04:01:23Z,2018-01-30T04:01:23Z,CONTRIBUTOR,Thanks.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,292585285
https://github.com/pydata/xarray/issues/1865#issuecomment-361410274,https://api.github.com/repos/pydata/xarray/issues/1865,361410274,MDEyOklzc3VlQ29tbWVudDM2MTQxMDI3NA==,6153603,2018-01-29T22:33:47Z,2018-01-29T22:33:47Z,CONTRIBUTOR,"Please add the label ""CF conventions"" to this issue","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,292585285
https://github.com/pydata/xarray/issues/1327#issuecomment-289135412,https://api.github.com/repos/pydata/xarray/issues/1327,289135412,MDEyOklzc3VlQ29tbWVudDI4OTEzNTQxMg==,6153603,2017-03-24T20:31:40Z,2017-03-24T20:31:40Z,CONTRIBUTOR,"Thanks for the heads-up @darothen. I browsed the issues to make sure I wasn't duplicating anything, but I must have overlooked the pull request you mentioned.
I have used a lambda function in the interim, so it is no issue if this addition waits until your pull-request is merged in.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,216833414