html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/5457#issuecomment-861550921,https://api.github.com/repos/pydata/xarray/issues/5457,861550921,MDEyOklzc3VlQ29tbWVudDg2MTU1MDkyMQ==,46687291,2021-06-15T14:31:59Z,2021-06-15T14:31:59Z,CONTRIBUTOR,"@dcherian @keewis I don't have permission to request reviews, but this has been open for almost a week so I wanted to nudge you.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,916710879 https://github.com/pydata/xarray/issues/4120#issuecomment-677939698,https://api.github.com/repos/pydata/xarray/issues/4120,677939698,MDEyOklzc3VlQ29tbWVudDY3NzkzOTY5OA==,46687291,2020-08-20T22:32:01Z,2020-08-20T22:53:14Z,CONTRIBUTOR,"My doubts on this are because self._replace are used elsewhere in the code. Changing from `_replace` to `copy` causes the tests on coarsen to fail, I am looking more into this now. ------------------ It seems that a condition of copy is that the data shapes match (variable.py line 947). If I run ``` ds = xr.tutorial.load_dataset(""air_temperature"") ds.air.coarsen(lat=5) ``` there is no problem, but once I add a `.mean()` to the end ``` ds = xr.tutorial.load_dataset(""air_temperature"") ds.air.coarsen(lat=5).mean() ``` The error is ``` ValueError: Data shape (2920, 5, 53) must match shape of object (2920, 25, 53) ```","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,630062936 https://github.com/pydata/xarray/pull/4360#issuecomment-677939502,https://api.github.com/repos/pydata/xarray/issues/4360,677939502,MDEyOklzc3VlQ29tbWVudDY3NzkzOTUwMg==,46687291,2020-08-20T22:31:19Z,2020-08-20T22:31:19Z,CONTRIBUTOR,This PR passes **kwargs into _coarsen_reshape and changes `_replace` to `copy` in the fx return of coarsen.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,683115879 https://github.com/pydata/xarray/issues/4120#issuecomment-677926857,https://api.github.com/repos/pydata/xarray/issues/4120,677926857,MDEyOklzc3VlQ29tbWVudDY3NzkyNjg1Nw==,46687291,2020-08-20T21:56:07Z,2020-08-20T21:59:48Z,CONTRIBUTOR,"@dcherian Could this be because the return of `variable.py/coarsen` or is it likely happening earlier in the fx? ``` return self._replace(data=func(reshaped, axis=axes, **kwargs)) ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,630062936 https://github.com/pydata/xarray/pull/3045#issuecomment-507773567,https://api.github.com/repos/pydata/xarray/issues/3045,507773567,MDEyOklzc3VlQ29tbWVudDUwNzc3MzU2Nw==,46687291,2019-07-02T17:30:59Z,2019-07-02T17:30:59Z,CONTRIBUTOR,Added those tests for for the raised Value Error.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460680578 https://github.com/pydata/xarray/issues/3026#issuecomment-507392001,https://api.github.com/repos/pydata/xarray/issues/3026,507392001,MDEyOklzc3VlQ29tbWVudDUwNzM5MjAwMQ==,46687291,2019-07-01T19:22:15Z,2019-07-01T19:22:15Z,CONTRIBUTOR,"This issue can be closed, and is addressed in pull request #3045 ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,456769766 https://github.com/pydata/xarray/pull/3045#issuecomment-507350527,https://api.github.com/repos/pydata/xarray/issues/3045,507350527,MDEyOklzc3VlQ29tbWVudDUwNzM1MDUyNw==,46687291,2019-07-01T17:14:08Z,2019-07-01T17:14:08Z,CONTRIBUTOR,"Checks could be more complicated, but I think this is ready to merge!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460680578 https://github.com/pydata/xarray/pull/3045#issuecomment-506070868,https://api.github.com/repos/pydata/xarray/issues/3045,506070868,MDEyOklzc3VlQ29tbWVudDUwNjA3MDg2OA==,46687291,2019-06-26T22:39:31Z,2019-06-26T22:39:31Z,CONTRIBUTOR,"> I would definitely recommend reading through our contributor's guide on how to setup a local environment for testing your code: http://xarray.pydata.org/en/stable/contributing.html > > It is _much_ easier to fix issues when you run tests locally rather than waiting on continuous integration tests (Travis-CI) to tell you that things are broken. Thank you was just needing to look into this.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460680578 https://github.com/pydata/xarray/pull/3045#issuecomment-506009244,https://api.github.com/repos/pydata/xarray/issues/3045,506009244,MDEyOklzc3VlQ29tbWVudDUwNjAwOTI0NA==,46687291,2019-06-26T19:17:14Z,2019-06-26T19:17:14Z,CONTRIBUTOR,"> FYI tests are failing with `E NameError: name '_rename_var_dims_helper' is not defined`: https://travis-ci.org/pydata/xarray/jobs/550940568 Huh not sure why that is. I can remove that function and see if it works then.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460680578 https://github.com/pydata/xarray/pull/3045#issuecomment-505651365,https://api.github.com/repos/pydata/xarray/issues/3045,505651365,MDEyOklzc3VlQ29tbWVudDUwNTY1MTM2NQ==,46687291,2019-06-25T22:50:51Z,2019-06-25T22:50:51Z,CONTRIBUTOR,I uninstalled the bot that automatically closed the pull request #3042 ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460680578 https://github.com/pydata/xarray/pull/3042#issuecomment-505611145,https://api.github.com/repos/pydata/xarray/issues/3042,505611145,MDEyOklzc3VlQ29tbWVudDUwNTYxMTE0NQ==,46687291,2019-06-25T20:32:33Z,2019-06-25T20:32:33Z,CONTRIBUTOR,"> @jukent check out the existing rename tests here (they're a bit over-complicated at the beginning): https://github.com/pydata/xarray/blob/master/xarray/tests/test_dataset.py#L2046-L2130 > > You could do something as simple as this: https://github.com/pydata/xarray/blob/master/xarray/tests/test_dataset.py#L2114-L2119 - i.e. start with a dataset, call a rename method, and compare the dataset with a manually constructed version of the expected result. > > Ping back with any issues Thanks @max-sixty. I added some very simple tests. I might copy more of the test_rename functions (if I tried to rename a variable to the same name for example)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436 https://github.com/pydata/xarray/pull/3042#issuecomment-505599777,https://api.github.com/repos/pydata/xarray/issues/3042,505599777,MDEyOklzc3VlQ29tbWVudDUwNTU5OTc3Nw==,46687291,2019-06-25T20:00:01Z,2019-06-25T20:00:01Z,CONTRIBUTOR,"> > #3026 > > There is some unexpected behavior. The new rename_dims function does not change the dimensions of the variables. Working on this now. > > Similarly rename_vars will rename the variable dimensions and variables, but not the dataset dimensions. I thought I was dealing with this with the _rename_indexes. But will have to keep working. This works now! But to do so I created three different renaming variable helper functions (var name only, var and dims, var dims only). I will clean this up since the majority of these three functions is the same.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436 https://github.com/pydata/xarray/pull/3042#issuecomment-505598969,https://api.github.com/repos/pydata/xarray/issues/3042,505598969,MDEyOklzc3VlQ29tbWVudDUwNTU5ODk2OQ==,46687291,2019-06-25T19:57:36Z,2019-06-25T19:57:36Z,CONTRIBUTOR,"> And tbc, we should add tests here. That will help clarify the issues above re exactly which items on the dataset each method should rename vs leave. Yes I need to add tests, but I don't have much experience with this yet. I will ask my team here to help me.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436 https://github.com/pydata/xarray/pull/3042#issuecomment-505587938,https://api.github.com/repos/pydata/xarray/issues/3042,505587938,MDEyOklzc3VlQ29tbWVudDUwNTU4NzkzOA==,46687291,2019-06-25T19:26:43Z,2019-06-25T19:26:43Z,CONTRIBUTOR,"> #3026 > > There is some unexpected behavior. The new rename_dims function does not change the dimensions of the variables. Working on this now. Similarly rename_vars will rename the variable dimensions and variables, but not the dataset dimensions. I thought I was dealing with this with the _rename_indexes. But will have to keep working.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436 https://github.com/pydata/xarray/pull/3042#issuecomment-505569846,https://api.github.com/repos/pydata/xarray/issues/3042,505569846,MDEyOklzc3VlQ29tbWVudDUwNTU2OTg0Ng==,46687291,2019-06-25T18:38:25Z,2019-06-25T18:38:25Z,CONTRIBUTOR,"pydata#3026 There is some unexpected behavior. The new rename_dims function does not change the dimensions of the variables. Working on this now.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436 https://github.com/pydata/xarray/issues/3026#issuecomment-505556932,https://api.github.com/repos/pydata/xarray/issues/3026,505556932,MDEyOklzc3VlQ29tbWVudDUwNTU1NjkzMg==,46687291,2019-06-25T18:04:06Z,2019-06-25T18:04:06Z,CONTRIBUTOR,Created pull request #3042 ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,456769766 https://github.com/pydata/xarray/issues/3026#issuecomment-505198712,https://api.github.com/repos/pydata/xarray/issues/3026,505198712,MDEyOklzc3VlQ29tbWVudDUwNTE5ODcxMg==,46687291,2019-06-24T22:02:27Z,2019-06-24T22:02:27Z,CONTRIBUTOR,I will submit a pull request to add separate rename dims and rename coords functions in a day or two.,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,456769766 https://github.com/pydata/xarray/issues/3026#issuecomment-505179831,https://api.github.com/repos/pydata/xarray/issues/3026,505179831,MDEyOklzc3VlQ29tbWVudDUwNTE3OTgzMQ==,46687291,2019-06-24T21:02:06Z,2019-06-24T21:02:06Z,CONTRIBUTOR,Should we close this issue?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,456769766 https://github.com/pydata/xarray/issues/3026#issuecomment-504212802,https://api.github.com/repos/pydata/xarray/issues/3026,504212802,MDEyOklzc3VlQ29tbWVudDUwNDIxMjgwMg==,46687291,2019-06-20T21:50:09Z,2019-06-20T22:10:50Z,CONTRIBUTOR,"``` import xarray as xr ds = xr.tutorial.open_dataset('air_temperature') ds.coords['y'] = ('lat',ds.lat) ds.coords['x'] = ('lon',ds.lon) ds_swappeddims = ds.swap_dims({'lat':'y','lon':'x'}) ds_swappeddims.drop(['x','y']) ``` Did you do something like this?/Is this what you are after but would like a cleaner solution?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,456769766 https://github.com/pydata/xarray/issues/3026#issuecomment-504180503,https://api.github.com/repos/pydata/xarray/issues/3026,504180503,MDEyOklzc3VlQ29tbWVudDUwNDE4MDUwMw==,46687291,2019-06-20T20:58:46Z,2019-06-20T20:58:46Z,CONTRIBUTOR,"I am looking into this, but first I am making sure I understand the relationship between coordinates and dimensions. Could you give me an example of when you would use this functionality?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,456769766