html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2905#issuecomment-781160118,https://api.github.com/repos/pydata/xarray/issues/2905,781160118,MDEyOklzc3VlQ29tbWVudDc4MTE2MDExOA==,1700203,2021-02-18T08:30:46Z,2021-02-18T08:30:46Z,CONTRIBUTOR,@keewis Thanks for looking into this and updating the PR! :),"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,434502234
https://github.com/pydata/xarray/pull/4018#issuecomment-631608640,https://api.github.com/repos/pydata/xarray/issues/4018,631608640,MDEyOklzc3VlQ29tbWVudDYzMTYwODY0MA==,1700203,2020-05-20T17:13:21Z,2020-05-20T17:13:21Z,CONTRIBUTOR,"Thanks, @dcherian! I'm happy to contribute 😊 ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,610687463
https://github.com/pydata/xarray/pull/4018#issuecomment-622965234,https://api.github.com/repos/pydata/xarray/issues/4018,622965234,MDEyOklzc3VlQ29tbWVudDYyMjk2NTIzNA==,1700203,2020-05-02T14:47:54Z,2020-05-02T14:47:54Z,CONTRIBUTOR,"Alright, I added the test. From my side, this would be ready. :)
Let me know if further changes to the tests or What's New are necessary.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,610687463
https://github.com/pydata/xarray/pull/4018#issuecomment-622389439,https://api.github.com/repos/pydata/xarray/issues/4018,622389439,MDEyOklzc3VlQ29tbWVudDYyMjM4OTQzOQ==,1700203,2020-05-01T13:32:02Z,2020-05-01T13:32:02Z,CONTRIBUTOR,@dcherian I think this would be ready for review now. I'd appreciate some guidance on the implementation of the tests; see above.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,610687463
https://github.com/pydata/xarray/pull/4018#issuecomment-622342323,https://api.github.com/repos/pydata/xarray/issues/4018,622342323,MDEyOklzc3VlQ29tbWVudDYyMjM0MjMyMw==,1700203,2020-05-01T10:51:20Z,2020-05-01T10:51:20Z,CONTRIBUTOR,"Currently, the error that is raised by `coerce_nc3_dtype` is not covered by tests.
A test could look something like this:
```python
def test_dtype_coercion_error(self):
for dtype in _nc3_dtype_coercions:
if dtype == ""bool"":
continue
# Create some data that cannot be coerced (cause it's a downcast)
dtype = np.dtype(dtype)
maxval = np.iinfo(dtype).max
x = np.array([0, 1, 2, maxval], dtype=dtype)
test_data = Dataset({""x"": (""t"", x, {})})
# Make sure a roundtrip fails
with pytest.raises(ValueError, match=""could not safely cast""):
self.roundtrip(test_data)
```
... but I'm not sure ...
* whether this would be desirable to test
* whether this PR should take care of this or not
* where in `test_backend.py` I would have to put the test case such that it's invoked only for netcdf3.
* I already found the `NetCDF3Only` class and `requires_scipy` decorator, but don't know which test class is responsible here ...","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,610687463
https://github.com/pydata/xarray/issues/4014#issuecomment-621102297,https://api.github.com/repos/pydata/xarray/issues/4014,621102297,MDEyOklzc3VlQ29tbWVudDYyMTEwMjI5Nw==,1700203,2020-04-29T09:56:11Z,2020-04-29T09:56:11Z,CONTRIBUTOR,"I'd be happy to open a PR, if such a behaviour is desired.
It seems like extending the [`_nc3_dtype_coercions` dict](https://github.com/pydata/xarray/blob/33a66d6380c26a59923922ee11e8ffcf0b4f379f/xarray/backends/netcdf3.py#L31) (and extending tests) is all that needs to be done here?
Suggestion: Add all [`uint` types supported by numpy](https://numpy.org/devdocs/user/basics.types.html):
```python
_nc3_dtype_coercions = {
""int64"": ""int32"",
""bool"": ""int8"",
""uint64"": ""int32"",
""uint32"": ""int32"",
""uint16"": ""int16"",
""uint8"": ""int8"",
}
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,608923222
https://github.com/pydata/xarray/pull/2905#issuecomment-560126145,https://api.github.com/repos/pydata/xarray/issues/2905,560126145,MDEyOklzc3VlQ29tbWVudDU2MDEyNjE0NQ==,1700203,2019-12-01T16:13:22Z,2019-12-01T16:13:49Z,CONTRIBUTOR,"@dcherian The most recent pipeline now fails in the `TestRasterio.test_rasterio_vrt` test. This seems unrelated... but I'm not sure if they might be connected.
Could you give me a hint on how to continue? Or need this be fixed elsewhere (or is already fixed) and I need to update this topic branch?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,434502234
https://github.com/pydata/xarray/issues/2097#issuecomment-484255028,https://api.github.com/repos/pydata/xarray/issues/2097,484255028,MDEyOklzc3VlQ29tbWVudDQ4NDI1NTAyOA==,1700203,2019-04-17T20:46:55Z,2019-04-17T20:46:55Z,CONTRIBUTOR,"I was wondering if this is still up for consideration?
> Thank you for your help! If I can be brought to better understand any constraints to adjacent issues, I can consider drafting a fix for this.
Same here.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,319329850