html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5734#issuecomment-1124203598,https://api.github.com/repos/pydata/xarray/issues/5734,1124203598,IC_kwDOAMm_X85DAfxO,20629530,2022-05-11T19:24:56Z,2022-05-11T19:25:11Z,CONTRIBUTOR,"> Presumably you haven't found any bugs?
Not for now,, but I haven't done much and it wasn't very complex.
> You can pass method as .mean(..., method=...)
Yes! I saw that, but I did search a bit. In fact, my idea was triggered partly because I'm lazy. My suggestion was to do something alike what xarray does with `keep_attrs` : a global/context option that changes the default value of `method`, so it doesn't need to be explicitly added everywhere.
> Note you can only blockwise if all members of a group are in a single block.
Oh! I didn't catch that. My test data was already appropriately chunked.
> Right now, I'd just like this to get merged :)
Haha, I understand. My idea, if pertinent, could be done in another PR.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,978356586
https://github.com/pydata/xarray/pull/5734#issuecomment-1124142026,https://api.github.com/repos/pydata/xarray/issues/5734,1124142026,IC_kwDOAMm_X85DAQvK,20629530,2022-05-11T18:18:17Z,2022-05-11T18:18:17Z,CONTRIBUTOR,"Hi @dcherian and @andersy005, thanks a lot for this PR and for flox. I'm currently trying this with our climate indices library (xclim) and it works well! I get a clear improvement in performance,
In xclim's indicators, all groupby operations are time resampling ops and the best performance is achieved with `method='blockwise'`, by far. Is there a plan to let users control the default method through something like `xr.set_options` ?
Like, `use_flox` could accept False, True or any method name? (The default still being `map-reduce`) ? What do you think? ","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,978356586