html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5731#issuecomment-977725089,https://api.github.com/repos/pydata/xarray/issues/5731,977725089,IC_kwDOAMm_X846Ruah,9466648,2021-11-24T10:08:04Z,2021-11-24T10:08:04Z,CONTRIBUTOR,Sorry for the unresponsiveness. I confirm that using the `asfloat` conversion also works for me. Should I close the issue or should I let you do it ?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,976790237
https://github.com/pydata/xarray/pull/5731#issuecomment-908040499,https://api.github.com/repos/pydata/xarray/issues/5731,908040499,IC_kwDOAMm_X842H5kz,41898282,2021-08-30T05:26:55Z,2021-08-31T15:59:38Z,CONTRIBUTOR,"## Unit Test Results
6 files 6 suites 49m 53s :stopwatch:
16 246 tests 14 512 :heavy_check_mark: 1 734 :zzz: 0 :x:
90 672 runs 82 496 :heavy_check_mark: 8 176 :zzz: 0 :x:
Results for commit 3dde39b1.
:recycle: This comment has been updated with latest results.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,976790237
https://github.com/pydata/xarray/pull/5731#issuecomment-904403621,https://api.github.com/repos/pydata/xarray/issues/5731,904403621,IC_kwDOAMm_X8416Bql,9466648,2021-08-24T07:43:28Z,2021-08-31T14:41:01Z,CONTRIBUTOR,"I included the proposed changes, thanks for the help.
However the new test I implemented does not go through and I fail to understand why. Would you be able to check ? The idea of the test is to ensure that lazy computations give the same results than normal ones. I tracked down the problem to line 1377 of `computation.py`:
```python
demeaned_da_a = da_a - da_a.mean(dim=dim) # <-- this one returns nan upon computation (.compute())
demeaned_da_b = da_b - da_b.mean(dim=dim) # <-- this one returns the correct value although the input is masked with nans in the same way
```
The values before the `mean` call are:
```
da_a.compute() = (x: 2, time: 2)>
array([[ 1., 2.],
[ 2., nan]])
da_b.compute() = (x: 2, time: 2)>
array([[ 1., 2.],
[ 1., nan]])
```
And for the means (dim is None):
```
da_a.mean(dim=dim).compute()= ()>
array(nan)
da_b.mean(dim=dim).compute()= ()>
array(1.33333333)
```
For non lazy computations everything seems fine.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,976790237
https://github.com/pydata/xarray/pull/5731#issuecomment-909300955,https://api.github.com/repos/pydata/xarray/issues/5731,909300955,IC_kwDOAMm_X842MtTb,9466648,2021-08-31T14:40:24Z,2021-08-31T14:40:24Z,CONTRIBUTOR,"I was referring to:
https://github.com/pydata/xarray/pull/5731#issuecomment-904403621
Otherwise I am working on the conflict with the main branch. Should be done soon.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,976790237
https://github.com/pydata/xarray/pull/5731#issuecomment-909095076,https://api.github.com/repos/pydata/xarray/issues/5731,909095076,IC_kwDOAMm_X842L7Ck,9466648,2021-08-31T10:10:15Z,2021-08-31T10:10:15Z,CONTRIBUTOR,"@keewis indeed this was the problem. I removed it and corrected one test which did not have the @require_dask decorator.
There is still a test error with the test arrays 5 and 6: the lazy array version do not return the same value than the usual corr. I consider this a different bug and just removed the tests with a TODO in the code.
The last commit pass the tests on my machine and I added the whats-new text to version 0.19.1.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,976790237
https://github.com/pydata/xarray/pull/5731#issuecomment-903574187,https://api.github.com/repos/pydata/xarray/issues/5731,903574187,IC_kwDOAMm_X84123Kr,9466648,2021-08-23T08:57:36Z,2021-08-23T08:57:36Z,CONTRIBUTOR,"Concerning the tests I added a test to check that lazy correlations have identical results to non-lazy correlations. But this is not directly related to the bug fix. Indeed there is a need to have a test that checks if the non-lazy correlation works without dask installed. The already existing test function `test_corr` does not have a `@requires_dask` decorator. But it did not fail as it should have. Not sure why.
About documenting the changes, I am not sure of the whats-new.rst format and I thus did not add it. Should I just add a bullet item on the top of the file ?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,976790237