html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5174#issuecomment-822700398,https://api.github.com/repos/pydata/xarray/issues/5174,822700398,MDEyOklzc3VlQ29tbWVudDgyMjcwMDM5OA==,9049976,2021-04-19T18:56:27Z,2021-04-19T18:57:00Z,CONTRIBUTOR,"> > I don't quite understand understand what you mean. [Like this?](https://github.com/pydata/xarray/pull/5174/commits/6ddb76cf146907e0a9276c25393153ea5c7245a2)
> 
> Forgive me not being clear. The current test with the version check is great. And I hadn't realized there was a released dask version — even better that the test is already running on both versions of the code.

Well... I see now there is also a duplicate test [here](https://github.com/tammasloughran/xarray/blob/master/xarray/tests/test_dask.py#L115), which fails when using the newer dask version. I don't understand why xarray goes to all the trouble of directly unit testing an external library. Makes more sense to me to only test the xarray wrapper for the dask functionality. I could add another version check there, or remove that test. What do you think?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860073545
https://github.com/pydata/xarray/pull/5174#issuecomment-822380259,https://api.github.com/repos/pydata/xarray/issues/5174,822380259,MDEyOklzc3VlQ29tbWVudDgyMjM4MDI1OQ==,9049976,2021-04-19T11:01:33Z,2021-04-19T11:01:33Z,CONTRIBUTOR,"> Are there any current tests for the error that break on the new version (i.e. because it doesn't raise an error)?

I don't quite understand understand what you mean. [Like this?](https://github.com/pydata/xarray/pull/5174/commits/6ddb76cf146907e0a9276c25393153ea5c7245a2)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,860073545