html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5135#issuecomment-820156925,https://api.github.com/repos/pydata/xarray/issues/5135,820156925,MDEyOklzc3VlQ29tbWVudDgyMDE1NjkyNQ==,367900,2021-04-15T06:36:38Z,2021-04-15T06:36:38Z,CONTRIBUTOR,"@aurghs it fixes it for both the test script in #5132 (using all three netCDF engines, ``netcdf4``, ``h5netcdf`` and ``scipy``) and for my original unit tests where I found the problem.","{""total_count"": 3, ""+1"": 3, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,853644364
https://github.com/pydata/xarray/pull/5135#issuecomment-816032139,https://api.github.com/repos/pydata/xarray/issues/5135,816032139,MDEyOklzc3VlQ29tbWVudDgxNjAzMjEzOQ==,367900,2021-04-08T18:10:58Z,2021-04-08T18:11:16Z,CONTRIBUTOR,"> LGTM. I don't know how we would test this...


For ensuring absolute paths, my MVCE in #5132 could be adapted.

Expansion of ~ might be trickier, but the [os.path.expanduser](https://docs.python.org/3/library/os.path.html#os.path.expanduser) docstring says

> On Unix, an initial ~ is replaced by the environment variable HOME if it is set

and

> On Windows, USERPROFILE will be used if set

so tests run with appropriate environment variables could be used with OS checking.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,853644364
https://github.com/pydata/xarray/pull/5135#issuecomment-816024426,https://api.github.com/repos/pydata/xarray/issues/5135,816024426,MDEyOklzc3VlQ29tbWVudDgxNjAyNDQyNg==,367900,2021-04-08T17:58:23Z,2021-04-08T17:58:23Z,CONTRIBUTOR,"> > @aurghs & @dcherian note that at the moment most backends accept `pathlib.Path` (but it is not tested), so the `isintance(..., str)` doesn't run `expandpath` in that case.
> 
> What do you suggest?

For Python 3.6+ expanduser works with paths, returning a string:

```
>>> os.path.expanduser(pathlib.Path(""~/file.nc""))
'/home/username/file.nc'
```
If its preferred to keep a Path instance, then the [Path.expanduser](https://docs.python.org/3/library/pathlib.html#pathlib.Path.expanduser) method is the equivalent.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,853644364
https://github.com/pydata/xarray/pull/5135#issuecomment-816011259,https://api.github.com/repos/pydata/xarray/issues/5135,816011259,MDEyOklzc3VlQ29tbWVudDgxNjAxMTI1OQ==,367900,2021-04-08T17:36:57Z,2021-04-08T17:36:57Z,CONTRIBUTOR,I think this would also fix #5132 if `os.path.abspath` was added around the `os.path.expanduser` calls.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,853644364