html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4559#issuecomment-723197430,https://api.github.com/repos/pydata/xarray/issues/4559,723197430,MDEyOklzc3VlQ29tbWVudDcyMzE5NzQzMA==,14314623,2020-11-06T17:15:33Z,2020-11-06T17:15:33Z,CONTRIBUTOR,Seems like all the other test are passing (minus the two upstream problems discussed before).,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,733789095
https://github.com/pydata/xarray/pull/4559#issuecomment-723168106,https://api.github.com/repos/pydata/xarray/issues/4559,723168106,MDEyOklzc3VlQ29tbWVudDcyMzE2ODEwNg==,14314623,2020-11-06T16:20:04Z,2020-11-06T16:20:04Z,CONTRIBUTOR,"I am not understanding why that `MinimumVersionPolicy` test is failing (or what it does haha). Is this something upstream, or should I fix?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,733789095
https://github.com/pydata/xarray/pull/4559#issuecomment-722513714,https://api.github.com/repos/pydata/xarray/issues/4559,722513714,MDEyOklzc3VlQ29tbWVudDcyMjUxMzcxNA==,14314623,2020-11-05T17:12:06Z,2020-11-05T17:12:06Z,CONTRIBUTOR,Ok I think this should be good to go. I have implemented all the requested changes. The remaining failures are related to other problems upstream (I think). Anything else I should add here?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,733789095
https://github.com/pydata/xarray/pull/4559#issuecomment-721831543,https://api.github.com/repos/pydata/xarray/issues/4559,721831543,MDEyOklzc3VlQ29tbWVudDcyMTgzMTU0Mw==,14314623,2020-11-04T16:22:43Z,2020-11-04T16:22:43Z,CONTRIBUTOR,Similarly on `MacOSX py38` this fails: TestDask.test_save_mfdataset_compute_false_roundtrip,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,733789095
https://github.com/pydata/xarray/pull/4559#issuecomment-721830832,https://api.github.com/repos/pydata/xarray/issues/4559,721830832,MDEyOklzc3VlQ29tbWVudDcyMTgzMDgzMg==,14314623,2020-11-04T16:21:35Z,2020-11-04T16:21:35Z,CONTRIBUTOR,I am getting some failures for `py38-upstream` (TestDataset.test_polyfit_warnings) that seem unrelated?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,733789095
https://github.com/pydata/xarray/pull/4559#issuecomment-721362748,https://api.github.com/repos/pydata/xarray/issues/4559,721362748,MDEyOklzc3VlQ29tbWVudDcyMTM2Mjc0OA==,14314623,2020-11-03T20:39:31Z,2020-11-03T20:39:31Z,CONTRIBUTOR,Do you think this works or are further changes needed? Many thanks for the guidance so far!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,733789095
https://github.com/pydata/xarray/pull/4559#issuecomment-720166781,https://api.github.com/repos/pydata/xarray/issues/4559,720166781,MDEyOklzc3VlQ29tbWVudDcyMDE2Njc4MQ==,14314623,2020-11-01T23:11:51Z,2020-11-01T23:11:51Z,CONTRIBUTOR,"I did have to fiddle with this a bit. I did change `.isnull()` to `np.isnan()` and replace the data of `weights`, otherwise the error would not be raised for the dask array at all.
This does not look terribly elegant to me, but passes tests locally. Waiting for the CI to see if the others pass aswell. Happy to make further changes, and thanks for all the input already.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,733789095
https://github.com/pydata/xarray/pull/4559#issuecomment-720020006,https://api.github.com/repos/pydata/xarray/issues/4559,720020006,MDEyOklzc3VlQ29tbWVudDcyMDAyMDAwNg==,14314623,2020-11-01T03:16:06Z,2020-11-01T03:16:06Z,CONTRIBUTOR,"The Ci environments without dask are failing. Should I add some pytest skip logic, or what is the best way to handle this?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,733789095