html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/4379#issuecomment-682038763,https://api.github.com/repos/pydata/xarray/issues/4379,682038763,MDEyOklzc3VlQ29tbWVudDY4MjAzODc2Mw==,6875882,2020-08-27T15:58:49Z,2020-08-27T15:58:49Z,CONTRIBUTOR,"Thanks for everybody's help! Also just wanted to say, you guys have an incredible test suite.","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 1, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,686495257 https://github.com/pydata/xarray/pull/4379#issuecomment-681999585,https://api.github.com/repos/pydata/xarray/issues/4379,681999585,MDEyOklzc3VlQ29tbWVudDY4MTk5OTU4NQ==,6875882,2020-08-27T14:52:27Z,2020-08-27T14:52:27Z,CONTRIBUTOR,I went with @keewis's last suggestion because I think it makes the most sense for deepcopy to behave as expected even with older versions of numpy,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,686495257 https://github.com/pydata/xarray/pull/4379#issuecomment-681097210,https://api.github.com/repos/pydata/xarray/issues/4379,681097210,MDEyOklzc3VlQ29tbWVudDY4MTA5NzIxMA==,6875882,2020-08-26T20:08:43Z,2020-08-26T20:08:43Z,CONTRIBUTOR,"Oh, sorry, I actually can reproduce it locally. Turns out arrays in numpy 1.15 don't have `__array_function__`. So this: ```python if deep: if hasattr(data, ""__array_function__"") or isinstance( data, dask_array_type ): data = copy.deepcopy(data) elif not isinstance(data, PandasIndexAdapter): # pandas.Index is immutable data = np.array(data) ``` could just be ```python if deep and not isinstance(data, PandasIndexAdapter): data = copy.deepcopy(data) ``` But I'm not familiar with `__array_function__` or why it's being used here, any thoughts?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,686495257 https://github.com/pydata/xarray/pull/4379#issuecomment-681041552,https://api.github.com/repos/pydata/xarray/issues/4379,681041552,MDEyOklzc3VlQ29tbWVudDY4MTA0MTU1Mg==,6875882,2020-08-26T18:13:32Z,2020-08-26T18:13:32Z,CONTRIBUTOR,"Weird, I can't reproduce that locally, even after reverting to numpy 1.15. Trying with a non-object class ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,686495257