html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4092#issuecomment-663138597,https://api.github.com/repos/pydata/xarray/issues/4092,663138597,MDEyOklzc3VlQ29tbWVudDY2MzEzODU5Nw==,12237157,2020-07-23T17:36:56Z,2020-07-23T17:38:38Z,CONTRIBUTOR,"My pleasure. Learnt a lot.
And it was a long-standing issue that was mentioned in a medium article about xarray looking for more contributors.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,624378150
https://github.com/pydata/xarray/pull/4092#issuecomment-660531286,https://api.github.com/repos/pydata/xarray/issues/4092,660531286,MDEyOklzc3VlQ29tbWVudDY2MDUzMTI4Ng==,12237157,2020-07-18T19:34:29Z,2020-07-18T19:34:29Z,CONTRIBUTOR,"> Thanks @aaronspring; this is looking very close! Just a few more minor suggestions.
I hope this is the final one. all tests pass. implemented your suggestions. took me a few commits, but I learned a lot. thanks for the guidance @spencerkclark ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,624378150
https://github.com/pydata/xarray/pull/4092#issuecomment-656101309,https://api.github.com/repos/pydata/xarray/issues/4092,656101309,MDEyOklzc3VlQ29tbWVudDY1NjEwMTMwOQ==,12237157,2020-07-09T12:35:49Z,2020-07-09T12:35:49Z,CONTRIBUTOR,dont understand why `isort` fails,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,624378150
https://github.com/pydata/xarray/pull/4092#issuecomment-654743050,https://api.github.com/repos/pydata/xarray/issues/4092,654743050,MDEyOklzc3VlQ29tbWVudDY1NDc0MzA1MA==,12237157,2020-07-07T10:00:18Z,2020-07-07T10:00:18Z,CONTRIBUTOR,"now aligns to `display_width`:
```python
for dw in [40,60,80,120]:
with xr.set_options(display_width=dw):
print(time[:2],dw,'\n')
```
```
CFTimeIndex([2000-01-01 00:00:00,
2000-01-02 00:00:00],
dtype='object',
length=2,
calendar='gregorian') 40
CFTimeIndex([2000-01-01 00:00:00, 2000-01-02 00:00:00],
dtype='object', length=2, calendar='gregorian') 60
CFTimeIndex([2000-01-01 00:00:00, 2000-01-02 00:00:00],
dtype='object', length=2, calendar='gregorian') 80
CFTimeIndex([2000-01-01 00:00:00, 2000-01-02 00:00:00], dtype='object', length=2, calendar='gregorian') 120
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,624378150
https://github.com/pydata/xarray/pull/4092#issuecomment-653742478,https://api.github.com/repos/pydata/xarray/issues/4092,653742478,MDEyOklzc3VlQ29tbWVudDY1Mzc0MjQ3OA==,12237157,2020-07-04T09:10:57Z,2020-07-04T09:10:57Z,CONTRIBUTOR,@spencerkclark I reimplemented the repr. Mostly went after the visuals. So now this looks like before but including calendar in the repr. Any more tests needed? Would you please give this a look?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,624378150
https://github.com/pydata/xarray/pull/4092#issuecomment-644035565,https://api.github.com/repos/pydata/xarray/issues/4092,644035565,MDEyOklzc3VlQ29tbWVudDY0NDAzNTU2NQ==,12237157,2020-06-15T10:08:21Z,2020-06-15T10:08:21Z,CONTRIBUTOR,I now reimplemented the visuals of pd.Index and also test against pd.Index.__repr__ @spencerkclark ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,624378150
https://github.com/pydata/xarray/pull/4092#issuecomment-641182167,https://api.github.com/repos/pydata/xarray/issues/4092,641182167,MDEyOklzc3VlQ29tbWVudDY0MTE4MjE2Nw==,12237157,2020-06-09T10:02:20Z,2020-06-09T15:31:03Z,CONTRIBUTOR,"now after clicking on the data item:
this PR is now ready for review. I don't understand why azure tests are failing.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,624378150
https://github.com/pydata/xarray/pull/4092#issuecomment-640096726,https://api.github.com/repos/pydata/xarray/issues/4092,640096726,MDEyOklzc3VlQ29tbWVudDY0MDA5NjcyNg==,12237157,2020-06-06T17:59:49Z,2020-06-06T23:22:20Z,CONTRIBUTOR,"I found a workaround with `to_index()` in `formatting.short_data_repr`. this is makes one test fail: xarray/tests/test_dask.py TestDataArrayAndDataset.test_dataarray_repr. is this ok or not a valid way to implement a cftimeindex.__repr__?
EDIT: I ensure now that `to_index` is only done when if CFTimeIndex.
Ready for review.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,624378150
https://github.com/pydata/xarray/pull/4092#issuecomment-640073445,https://api.github.com/repos/pydata/xarray/issues/4092,640073445,MDEyOklzc3VlQ29tbWVudDY0MDA3MzQ0NQ==,12237157,2020-06-06T14:54:31Z,2020-06-06T14:54:31Z,CONTRIBUTOR,"Currently only the cftimeindex repr shows the calendar property. I aim to get it into the dataset/dataarray repr.
would it be a good idea to modify `formatting.py.array_repr(array)`? IndexVariable uses this repr. Once `time` is a coordinate, it becomes an IndexVariable. but the index variable doesnt have this cftime.calender property anymore. Should I try to add this calendar property to the array or would this not be desired?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,624378150
https://github.com/pydata/xarray/pull/4092#issuecomment-638913996,https://api.github.com/repos/pydata/xarray/issues/4092,638913996,MDEyOklzc3VlQ29tbWVudDYzODkxMzk5Ng==,12237157,2020-06-04T15:10:46Z,2020-06-04T15:10:46Z,CONTRIBUTOR,"I do understand the meaning of this last sentence @spencerkclark
> My sense is that it is more important that indexes with the same date type have the same `calendar` attribute than that the `calendar` argument passed to `cftime_range` is propagated verbatim to the index it produces. What do you think?
Should I rather test on cftimeindex created in a different way?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,624378150
https://github.com/pydata/xarray/pull/4092#issuecomment-638779099,https://api.github.com/repos/pydata/xarray/issues/4092,638779099,MDEyOklzc3VlQ29tbWVudDYzODc3OTA5OQ==,12237157,2020-06-04T11:02:00Z,2020-06-04T11:02:00Z,CONTRIBUTOR,"This doesnt change the html repr yet: when clicking on the data symbol, calendar is not shown in the printout. I will further try to fix this","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,624378150
https://github.com/pydata/xarray/pull/4092#issuecomment-638302372,https://api.github.com/repos/pydata/xarray/issues/4092,638302372,MDEyOklzc3VlQ29tbWVudDYzODMwMjM3Mg==,12237157,2020-06-03T16:17:01Z,2020-06-03T16:17:01Z,CONTRIBUTOR,"I was hoping to inherit from pandas like:
```python
def __repr__(self):
super().__repr__()
return self.__repr__().strip("")"")+f"", calendar={self.calendar}')""
```
But I will now try to rebuild as in `pandas`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,624378150
https://github.com/pydata/xarray/pull/4092#issuecomment-637369697,https://api.github.com/repos/pydata/xarray/issues/4092,637369697,MDEyOklzc3VlQ29tbWVudDYzNzM2OTY5Nw==,12237157,2020-06-02T08:10:24Z,2020-06-02T08:10:24Z,CONTRIBUTOR,"> > how should I extend the `__repr__` coming from `pd.Index`
>
> if you define a `__repr__` method under `CFTimeIndex`, won't it override `pd.Index.__repr__`?
Yes. I will do that. My question was whether should replicate the pd.Index.__repr__ or try to import or inherit as much as I can from pandas?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,624378150