html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/3894#issuecomment-1101553689,https://api.github.com/repos/pydata/xarray/issues/3894,1101553689,IC_kwDOAMm_X85BqGAZ,1386642,2022-04-18T16:41:39Z,2022-04-18T16:41:39Z,CONTRIBUTOR,"I think the issue is still valid, we just couldn't think of what to name the new API.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,588112617
https://github.com/pydata/xarray/issues/3894#issuecomment-676633628,https://api.github.com/repos/pydata/xarray/issues/3894,676633628,MDEyOklzc3VlQ29tbWVudDY3NjYzMzYyOA==,3460034,2020-08-19T20:04:10Z,2020-08-19T20:24:38Z,CONTRIBUTOR,"Would this proposal mean that subsetting variables with `__getitem__` would no longer work? If so, I'd make the humble request as a downstream user/library contributor for it to have a very generous deprecation period, since it is core functionality I rely on a lot (and include in many tutorials).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,588112617
https://github.com/pydata/xarray/issues/3894#issuecomment-675057700,https://api.github.com/repos/pydata/xarray/issues/3894,675057700,MDEyOklzc3VlQ29tbWVudDY3NTA1NzcwMA==,1386642,2020-08-17T19:03:55Z,2020-08-17T19:03:55Z,CONTRIBUTOR,"NVM, `get` is already a method. Maybe we could overload it?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,588112617
https://github.com/pydata/xarray/issues/3894#issuecomment-675056880,https://api.github.com/repos/pydata/xarray/issues/3894,675056880,MDEyOklzc3VlQ29tbWVudDY3NTA1Njg4MA==,1386642,2020-08-17T19:02:24Z,2020-08-17T19:02:24Z,CONTRIBUTOR,"Or maybe ""get"" since it's a synonym of ""select"" that isn't overloaded with spatial indexing in the code base.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,588112617
https://github.com/pydata/xarray/issues/3894#issuecomment-675055276,https://api.github.com/repos/pydata/xarray/issues/3894,675055276,MDEyOklzc3VlQ29tbWVudDY3NTA1NTI3Ng==,1386642,2020-08-17T18:59:05Z,2020-08-17T18:59:05Z,CONTRIBUTOR,"> Is there a way in mypy we could use something like overload to specify the above contract here, as an alternative to another method?

That is correct. The output type is predictable from the inputs types. With #4144, `mypy` may have a chance at detecting this kind of error. Still, I don't know how many users use type-checking. I expect most will only discover this problem at runtime.

>  It would be better to have an explicit method for subsetting Dataset variables.

I agree. `sel_vars` is more clear IMO since `subset` could apply to the coordinates too e.g. a spatial subset.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,588112617