html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/3425#issuecomment-546089446,https://api.github.com/repos/pydata/xarray/issues/3425,546089446,MDEyOklzc3VlQ29tbWVudDU0NjA4OTQ0Ng==,4806877,2019-10-24T20:29:22Z,2019-10-24T20:29:22Z,CONTRIBUTOR,"> Besides variable names, we probably need to somehow handle overflow for variables that have a long list of dimension labels. These are handled in the same way as long variable names, they truncate with an ellipsis and then expand on hover.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-546088350,https://api.github.com/repos/pydata/xarray/issues/3425,546088350,MDEyOklzc3VlQ29tbWVudDU0NjA4ODM1MA==,4806877,2019-10-24T20:26:17Z,2019-10-24T20:26:17Z,CONTRIBUTOR,I opened [a PR](#3444) and included a small test. It can probably go in while we work on a more complete testing infrastructure.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-546082146,https://api.github.com/repos/pydata/xarray/issues/3425,546082146,MDEyOklzc3VlQ29tbWVudDU0NjA4MjE0Ng==,4806877,2019-10-24T20:09:44Z,2019-10-24T20:09:44Z,CONTRIBUTOR,"> I looks like we'll need to fix a couple of issues (the channel coordinate looks weird), but maybe it is not related to the front-end. I am opening a PR. I didn't escape dtypes and this dtype is ` ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-545973962,https://api.github.com/repos/pydata/xarray/issues/3425,545973962,MDEyOklzc3VlQ29tbWVudDU0NTk3Mzk2Mg==,4806877,2019-10-24T15:32:08Z,2019-10-24T15:32:08Z,CONTRIBUTOR,"> I've noticed an issue with the alignment of attributes in jupyterlab (1.1.4) (Firefox 69.0.3): I'm taking a look at the jlab css. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-545928015,https://api.github.com/repos/pydata/xarray/issues/3425,545928015,MDEyOklzc3VlQ29tbWVudDU0NTkyODAxNQ==,4806877,2019-10-24T13:51:45Z,2019-10-24T13:51:45Z,CONTRIBUTOR,"@benbovy just to make double sure, you are happy with this new feature being off by default right?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-545916227,https://api.github.com/repos/pydata/xarray/issues/3425,545916227,MDEyOklzc3VlQ29tbWVudDU0NTkxNjIyNw==,4806877,2019-10-24T13:24:45Z,2019-10-24T13:24:45Z,CONTRIBUTOR,So maybe one more rebase will do it?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-545648937,https://api.github.com/repos/pydata/xarray/issues/3425,545648937,MDEyOklzc3VlQ29tbWVudDU0NTY0ODkzNw==,4806877,2019-10-23T21:43:02Z,2019-10-23T21:43:02Z,CONTRIBUTOR,"Well, I rebased. Hopefully it'll pass now. I consider this done unless someone wants more docs or more tests.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-545647958,https://api.github.com/repos/pydata/xarray/issues/3425,545647958,MDEyOklzc3VlQ29tbWVudDU0NTY0Nzk1OA==,4806877,2019-10-23T21:39:52Z,2019-10-23T21:39:52Z,CONTRIBUTOR,I am 90% sure [this failure](https://github.com/pydata/xarray/pull/3425/checks?check_run_id=272331486) is unrelated. Maybe I should rebase now that #3436 has landed?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-545637867,https://api.github.com/repos/pydata/xarray/issues/3425,545637867,MDEyOklzc3VlQ29tbWVudDU0NTYzNzg2Nw==,4806877,2019-10-23T21:10:33Z,2019-10-23T21:10:33Z,CONTRIBUTOR,Oh. The dask version in ci doesn't have `_repr_html_`. I'll add a version checker to the test.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-545605598,https://api.github.com/repos/pydata/xarray/issues/3425,545605598,MDEyOklzc3VlQ29tbWVudDU0NTYwNTU5OA==,4806877,2019-10-23T19:43:54Z,2019-10-23T19:43:54Z,CONTRIBUTOR,Otherwise I think all that is left is adding docs. Also I want to confirm that this should be an experimental feature (off by default). ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-545597657,https://api.github.com/repos/pydata/xarray/issues/3425,545597657,MDEyOklzc3VlQ29tbWVudDU0NTU5NzY1Nw==,4806877,2019-10-23T19:23:16Z,2019-10-23T19:23:16Z,CONTRIBUTOR,I added some tests. I can add more if anyone has a test case that they want to be sure is covered. ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-545545019,https://api.github.com/repos/pydata/xarray/issues/3425,545545019,MDEyOklzc3VlQ29tbWVudDU0NTU0NTAxOQ==,4806877,2019-10-23T17:11:51Z,2019-10-23T17:11:51Z,CONTRIBUTOR,"Ok I am going to write some tests now. I updated the gist. Do people like the names ""classic"" and ""html"" for the display_style options? Another option would be ""classic"" and ""rich"".","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-545542947,https://api.github.com/repos/pydata/xarray/issues/3425,545542947,MDEyOklzc3VlQ29tbWVudDU0NTU0Mjk0Nw==,4806877,2019-10-23T17:07:33Z,2019-10-23T17:08:56Z,CONTRIBUTOR,~~Oh I was looking at bytes not len.~~ I didn't have `.encode('utf8')`,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-545539785,https://api.github.com/repos/pydata/xarray/issues/3425,545539785,MDEyOklzc3VlQ29tbWVudDU0NTUzOTc4NQ==,4806877,2019-10-23T16:59:38Z,2019-10-23T16:59:38Z,CONTRIBUTOR,"I'm still worried about size, but minifying the css and even minifying the html did not make a big difference. It looks like the html_repr for rasm is 38kb .","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-545177297,https://api.github.com/repos/pydata/xarray/issues/3425,545177297,MDEyOklzc3VlQ29tbWVudDU0NTE3NzI5Nw==,4806877,2019-10-22T22:08:49Z,2019-10-22T22:08:49Z,CONTRIBUTOR,Ok I think I've addressed all the comments. I just updated the gist with the latest output. Tomorrow I'll start adding tests. The css is now ~300 lines and it gets injected everytime the dataset is rendered. I'm not sure if that is considered too long and if it is I don't quite know what to do about it. ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-545074728,https://api.github.com/repos/pydata/xarray/issues/3425,545074728,MDEyOklzc3VlQ29tbWVudDU0NTA3NDcyOA==,4806877,2019-10-22T17:42:03Z,2019-10-22T17:42:03Z,CONTRIBUTOR,"Is there ever a situation in which dimensions would be expandable? It seems like it is hard-coded to collapsed. I am trying to generalize the css to reduce the length.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-544980677,https://api.github.com/repos/pydata/xarray/issues/3425,544980677,MDEyOklzc3VlQ29tbWVudDU0NDk4MDY3Nw==,4806877,2019-10-22T14:08:00Z,2019-10-22T14:08:00Z,CONTRIBUTOR,"I just updated the gist with these changes: - got rid of alternating data colors in preview - fixed icon alignment in row, and rest of data in row - got rid of some not-useful spans - changed from underline to bold for index coords","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-544957163,https://api.github.com/repos/pydata/xarray/issues/3425,544957163,MDEyOklzc3VlQ29tbWVudDU0NDk1NzE2Mw==,4806877,2019-10-22T13:17:28Z,2019-10-22T13:17:28Z,CONTRIBUTOR,Yeah the data preview is also shifted vertically. ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-544768411,https://api.github.com/repos/pydata/xarray/issues/3425,544768411,MDEyOklzc3VlQ29tbWVudDU0NDc2ODQxMQ==,4806877,2019-10-22T01:01:22Z,2019-10-22T01:01:22Z,CONTRIBUTOR,"Yeah I agree that is a strange part of the original PR. The version in the fiddle doesn't do that, so I'd really like to hear back from @benbovy about whether the fiddle css is more uptodate.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810 https://github.com/pydata/xarray/pull/3425#issuecomment-544731859,https://api.github.com/repos/pydata/xarray/issues/3425,544731859,MDEyOklzc3VlQ29tbWVudDU0NDczMTg1OQ==,4806877,2019-10-21T22:18:14Z,2019-10-21T22:18:14Z,CONTRIBUTOR,"I don't really like how the ``attrs`` look without the alignment of keys and values. I will think about how to make that more legible ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,510294810