html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/3194#issuecomment-519760729,https://api.github.com/repos/pydata/xarray/issues/3194,519760729,MDEyOklzc3VlQ29tbWVudDUxOTc2MDcyOQ==,12229877,2019-08-09T03:10:37Z,2019-08-09T03:10:37Z,CONTRIBUTOR,"[My config](https://github.com/Zac-HD/hypothesmith/blob/master/tox.ini) uses `tox` and `bash` instead of pre-commit. Doesn't work well for Windows, but it's a tiny Python script to glob for .py files and `subprocess.run` the pyupgrade command. Balancing powerful CI against new-contributor-friendliness is hard! ```ini [testenv:check] deps = -r requirements.txt whitelist_externals = bash commands = autoflake --recursive --in-place --remove-all-unused-imports --remove-duplicate-keys --remove-unused-variables . bash -c \""pyupgrade --py36-plus **.py\"" isort --recursive --apply . black . flake8 mypy --config-file=tox.ini . src/ bandit --recursive --exclude=./.tox/** --skip=B101,B110,B310 --quiet . ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,478690528 https://github.com/pydata/xarray/pull/3194#issuecomment-519720166,https://api.github.com/repos/pydata/xarray/issues/3194,519720166,MDEyOklzc3VlQ29tbWVudDUxOTcyMDE2Ng==,12229877,2019-08-08T23:14:19Z,2019-08-08T23:14:19Z,CONTRIBUTOR,"The author pushes pre-commit pretty hard, but that shouldn't be a problem for Xarray as we're already using it. Then `pre-commit run --all-files` will execute it. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,478690528 https://github.com/pydata/xarray/pull/3194#issuecomment-519713454,https://api.github.com/repos/pydata/xarray/issues/3194,519713454,MDEyOklzc3VlQ29tbWVudDUxOTcxMzQ1NA==,12229877,2019-08-08T22:42:12Z,2019-08-08T22:42:12Z,CONTRIBUTOR,"In all seriousness, pyupgrade will do this and more automatically with the --py3-only option. I'd add it to CI! ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,478690528