html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3042#issuecomment-505611145,https://api.github.com/repos/pydata/xarray/issues/3042,505611145,MDEyOklzc3VlQ29tbWVudDUwNTYxMTE0NQ==,46687291,2019-06-25T20:32:33Z,2019-06-25T20:32:33Z,CONTRIBUTOR,"> @jukent check out the existing rename tests here (they're a bit over-complicated at the beginning): https://github.com/pydata/xarray/blob/master/xarray/tests/test_dataset.py#L2046-L2130
> 
> You could do something as simple as this: https://github.com/pydata/xarray/blob/master/xarray/tests/test_dataset.py#L2114-L2119 - i.e. start with a dataset, call a rename method, and compare the dataset with a manually constructed version of the expected result.
> 
> Ping back with any issues

Thanks @max-sixty. I added some very simple tests. I might copy more of the test_rename functions (if I tried to rename a variable to the same name for example)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436
https://github.com/pydata/xarray/pull/3042#issuecomment-505599777,https://api.github.com/repos/pydata/xarray/issues/3042,505599777,MDEyOklzc3VlQ29tbWVudDUwNTU5OTc3Nw==,46687291,2019-06-25T20:00:01Z,2019-06-25T20:00:01Z,CONTRIBUTOR,"> > #3026
> > There is some unexpected behavior. The new rename_dims function does not change the dimensions of the variables. Working on this now.
> 
> Similarly rename_vars will rename the variable dimensions and variables, but not the dataset dimensions. I thought I was dealing with this with the _rename_indexes. But will have to keep working.

This works now! But to do so I created three different renaming variable helper functions (var name only, var and dims, var dims only). I will clean this up since the majority of these three functions is the same.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436
https://github.com/pydata/xarray/pull/3042#issuecomment-505598969,https://api.github.com/repos/pydata/xarray/issues/3042,505598969,MDEyOklzc3VlQ29tbWVudDUwNTU5ODk2OQ==,46687291,2019-06-25T19:57:36Z,2019-06-25T19:57:36Z,CONTRIBUTOR,"> And tbc, we should add tests here. That will help clarify the issues above re exactly which items on the dataset each method should rename vs leave.

Yes I need to add tests, but I don't have much experience with this yet. I will ask my team here to help me.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436
https://github.com/pydata/xarray/pull/3042#issuecomment-505587938,https://api.github.com/repos/pydata/xarray/issues/3042,505587938,MDEyOklzc3VlQ29tbWVudDUwNTU4NzkzOA==,46687291,2019-06-25T19:26:43Z,2019-06-25T19:26:43Z,CONTRIBUTOR,"> #3026
> 
> There is some unexpected behavior. The new rename_dims function does not change the dimensions of the variables. Working on this now.

Similarly rename_vars will rename the variable dimensions and variables, but not the dataset dimensions. I thought I was dealing with this with the _rename_indexes. But will have to keep working.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436
https://github.com/pydata/xarray/pull/3042#issuecomment-505569846,https://api.github.com/repos/pydata/xarray/issues/3042,505569846,MDEyOklzc3VlQ29tbWVudDUwNTU2OTg0Ng==,46687291,2019-06-25T18:38:25Z,2019-06-25T18:38:25Z,CONTRIBUTOR,"pydata#3026

There is some unexpected behavior. The new rename_dims function does not change the dimensions of the variables. Working on this now.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460562436