html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/2968#issuecomment-493632403,https://api.github.com/repos/pydata/xarray/issues/2968,493632403,MDEyOklzc3VlQ29tbWVudDQ5MzYzMjQwMw==,223250,2019-05-18T00:18:37Z,2019-05-18T00:18:37Z,CONTRIBUTOR,@dcherian added. Let me know if you want any changes.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,445045305 https://github.com/pydata/xarray/pull/2968#issuecomment-493497801,https://api.github.com/repos/pydata/xarray/issues/2968,493497801,MDEyOklzc3VlQ29tbWVudDQ5MzQ5NzgwMQ==,223250,2019-05-17T15:34:23Z,2019-05-17T15:34:23Z,CONTRIBUTOR,Changed to simply add examples to `DataArrayRolling.reduce()`. I changed the original description accordingly.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,445045305 https://github.com/pydata/xarray/pull/2968#issuecomment-493494703,https://api.github.com/repos/pydata/xarray/issues/2968,493494703,MDEyOklzc3VlQ29tbWVudDQ5MzQ5NDcwMw==,223250,2019-05-17T15:25:45Z,2019-05-17T15:26:03Z,CONTRIBUTOR,"Actually, every window has at least 1 valid value, so this change isn't really needed at all. I'll remove the code changes, and change the added example to show a working example of what I wanted. I will say that `min_periods` isn't the most obvious name for this parameter--I'm struggling to figure out how the number of valid observations in a window is related to periods or periodicity. Would it be reasonable to deprecate `min_periods` and change it to something like `min_observations`?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,445045305 https://github.com/pydata/xarray/pull/2968#issuecomment-493489589,https://api.github.com/repos/pydata/xarray/issues/2968,493489589,MDEyOklzc3VlQ29tbWVudDQ5MzQ4OTU4OQ==,223250,2019-05-17T15:10:49Z,2019-05-17T15:10:49Z,CONTRIBUTOR,"@mathause, thank you, I didn't realize that. I'll make those changes.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,445045305