html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/2767#issuecomment-469088112,https://api.github.com/repos/pydata/xarray/issues/2767,469088112,MDEyOklzc3VlQ29tbWVudDQ2OTA4ODExMg==,223250,2019-03-04T01:22:04Z,2019-03-04T01:22:04Z,CONTRIBUTOR,No worries--thanks for merging!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,409618228 https://github.com/pydata/xarray/pull/2767#issuecomment-468980810,https://api.github.com/repos/pydata/xarray/issues/2767,468980810,MDEyOklzc3VlQ29tbWVudDQ2ODk4MDgxMA==,223250,2019-03-03T02:28:02Z,2019-03-03T02:28:02Z,CONTRIBUTOR,Rebased to fix the NEWS conflict.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,409618228 https://github.com/pydata/xarray/pull/2767#issuecomment-467568430,https://api.github.com/repos/pydata/xarray/issues/2767,467568430,MDEyOklzc3VlQ29tbWVudDQ2NzU2ODQzMA==,223250,2019-02-26T19:02:23Z,2019-02-26T19:02:23Z,CONTRIBUTOR,@shoyer I force pushed the requested changes. Please let me know if there is anything else. Thanks!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,409618228 https://github.com/pydata/xarray/pull/2767#issuecomment-466463669,https://api.github.com/repos/pydata/xarray/issues/2767,466463669,MDEyOklzc3VlQ29tbWVudDQ2NjQ2MzY2OQ==,223250,2019-02-22T16:47:11Z,2019-02-22T16:47:11Z,CONTRIBUTOR,"> I agree that it makes sense to recompute dimensions from variables. Okay, that's what this PR already did (via the call to `_replace_with_new_dims`). Rebased on master. From my perspective, this should be good to go.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,409618228 https://github.com/pydata/xarray/pull/2767#issuecomment-466083575,https://api.github.com/repos/pydata/xarray/issues/2767,466083575,MDEyOklzc3VlQ29tbWVudDQ2NjA4MzU3NQ==,223250,2019-02-21T17:11:05Z,2019-02-21T17:11:05Z,CONTRIBUTOR,"@shoyer I'm sure you're busy... wondering if you might have time to review this (or direct it to someone else to review)? Other than my question above, it should be pretty straightforward.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,409618228 https://github.com/pydata/xarray/pull/2767#issuecomment-463078403,https://api.github.com/repos/pydata/xarray/issues/2767,463078403,MDEyOklzc3VlQ29tbWVudDQ2MzA3ODQwMw==,223250,2019-02-13T06:38:43Z,2019-02-13T06:38:43Z,CONTRIBUTOR,"I was looking for this functionality and ran across #1949. There was one bit of behavior that was unclear to me. Say I have ```python In [6]: data = xr.Dataset({'A': (['x', 'y'], np.random.randn(2, 3)), ...: 'B': ('x', np.random.randn(2)), ...: 'x': ['a', 'b'], 'z': np.pi}) In [7]: data Out[7]: Dimensions: (x: 2, y: 3) Coordinates: * x (x) Dimensions: () Data variables: z float64 3.142 ``` In this case, I dropped `x`, but because that eliminated variable `A`, I also dropped my `y` dimension, since `A` was the only variable using `y`. At one point, I implemented this slightly differently, which instead gave ```python In [8]: data.drop_dims('x') Out[8]: Dimensions: (y: 3) Dimensions without coordinates: y Data variables: z float64 3.142 ``` In some ways, this seems preferable, especially if `y` has coordinates. The only downside I can see is that this version called `Dataset._replace_vars_and_dims()`, the docstring for which says it's deprecated (although it's still widely used).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,409618228