html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2107#issuecomment-394058188,https://api.github.com/repos/pydata/xarray/issues/2107,394058188,MDEyOklzc3VlQ29tbWVudDM5NDA1ODE4OA==,6164157,2018-06-02T04:47:05Z,2018-06-02T04:47:05Z,CONTRIBUTOR,"OK, somehow the rebasing thing broke everything and I am at a loss. @shoyer, @dcherian please guide me on how to proceed. Sorry.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-393897686,https://api.github.com/repos/pydata/xarray/issues/2107,393897686,MDEyOklzc3VlQ29tbWVudDM5Mzg5NzY4Ng==,6164157,2018-06-01T14:27:48Z,2018-06-01T14:27:48Z,CONTRIBUTOR,"Thanks @shoyer. I fixed everything except for the coverall part, which is weird. The lines it marks as untested are the function `_line_facetgrid`, which the main function that performs all of the testing. I suspect that it simply doesn't run my new tests for some reason. When I run `pytest` locally these lines do get tested (I verified by adding `print` commands there).
Should I add decorators like `pytest.mark.something`for coverall to notice these tests?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-393018032,https://api.github.com/repos/pydata/xarray/issues/2107,393018032,MDEyOklzc3VlQ29tbWVudDM5MzAxODAzMg==,6164157,2018-05-30T03:22:16Z,2018-05-30T03:22:16Z,CONTRIBUTOR,"I wrote some tests and also followed @shoyer's suggestion to make the plots look more like seaborn. Here's what it looks like now:

![f1](https://user-images.githubusercontent.com/6164157/40697164-ff7ef804-6396-11e8-8175-8302d5acc84a.png)
![f3](https://user-images.githubusercontent.com/6164157/40697165-ff89e17e-6396-11e8-989b-20904771a566.png)
![f4](https://user-images.githubusercontent.com/6164157/40697166-ff9794f4-6396-11e8-949c-af251d1055fe.png)

I also had to refactor the code adding legend to a line plot to avoid duplicities.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-388635575,https://api.github.com/repos/pydata/xarray/issues/2107,388635575,MDEyOklzc3VlQ29tbWVudDM4ODYzNTU3NQ==,6164157,2018-05-13T15:34:39Z,2018-05-13T15:34:39Z,CONTRIBUTOR,"@jhamman @shoyer Sorry for being a noob, but what exactly do you mean by ""add some basic unit tests""? you mean writing new functions that will verify that stuff works as it should, or that the new addition does not mess up previous plotting behavior?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-387196472,https://api.github.com/repos/pydata/xarray/issues/2107,387196472,MDEyOklzc3VlQ29tbWVudDM4NzE5NjQ3Mg==,6164157,2018-05-07T20:33:19Z,2018-05-07T20:33:19Z,CONTRIBUTOR,was simpler than I thought. @shoyer I added the plots.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-386922376,https://api.github.com/repos/pydata/xarray/issues/2107,386922376,MDEyOklzc3VlQ29tbWVudDM4NjkyMjM3Ng==,6164157,2018-05-06T22:40:43Z,2018-05-07T20:31:19Z,CONTRIBUTOR,"Example code to demonstrate functionality:

```python
import xarray as xr
import numpy as np
import pandas as pd

np.random.seed(0)
tm = pd.date_range('2000-01-01', end='2000-01-02', freq='H')
d4 = xr.DataArray(np.random.randn(len(tm), 6, 3, 3),
                  dims=['time', 'x', 'text_dim',  'z'],
                  coords=[tm, range(6), ['foo', 'bar', 'foobar'], [3.5, 4.9, 6.7]],
                  name='arr_name')
d3 = d4[..., 0].drop('z')
d2 = d3[..., 0].drop('text_dim')

# generate a faceted 4-dimensional plot:
d4.plot(hue='text_dim', col='x', row='z')
# or equivalently:
# d4.plot.line(x='time', col='x', row='z')
````
![f1](https://user-images.githubusercontent.com/6164157/39723367-4e6ace02-524e-11e8-89a5-304d171a12a4.png)

````python
d3.plot(col='x', row='text_dim')
````
![f2](https://user-images.githubusercontent.com/6164157/39723443-8a3cdeac-524e-11e8-9921-14455e31761b.png)

````python
d2.plot(hue='x')
````
![f3](https://user-images.githubusercontent.com/6164157/39723457-96afd4a0-524e-11e8-8be0-25b4e654da08.png)

````python
d3.plot.line(col='x', col_wrap=3, hue='text_dim')
````
![f4](https://user-images.githubusercontent.com/6164157/39723476-a230b5c4-524e-11e8-904b-d52288021a2b.png)

","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674
https://github.com/pydata/xarray/pull/2107#issuecomment-387174940,https://api.github.com/repos/pydata/xarray/issues/2107,387174940,MDEyOklzc3VlQ29tbWVudDM4NzE3NDk0MA==,6164157,2018-05-07T19:24:12Z,2018-05-07T19:24:12Z,CONTRIBUTOR,I found some bugs. I'll reopen when I fix them.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674