html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/1835#issuecomment-358926430,https://api.github.com/repos/pydata/xarray/issues/1835,358926430,MDEyOklzc3VlQ29tbWVudDM1ODkyNjQzMA==,10512793,2018-01-19T10:26:17Z,2018-01-19T10:26:17Z,CONTRIBUTOR,"I've pushed an updated version with a successful test on my machine. I've modified the dataset name in the test case to ensure it has 88 characters (the filepath on github has to have less than 88 characters of course, this seems like a safe assumption). I've made some formatting changes to netCDF4_.py to pass the pyflake tests. I've moved the import statement for LooseVersion to the start of the script. Thanks for the reviews and advice @shoyer ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288957853 https://github.com/pydata/xarray/pull/1835#issuecomment-358336467,https://api.github.com/repos/pydata/xarray/issues/1835,358336467,MDEyOklzc3VlQ29tbWVudDM1ODMzNjQ2Nw==,10512793,2018-01-17T15:18:21Z,2018-01-17T15:18:21Z,CONTRIBUTOR,"There are some other small issues I need to deal with, I'll leave a message when I've sorted those out","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288957853 https://github.com/pydata/xarray/pull/1835#issuecomment-358333272,https://api.github.com/repos/pydata/xarray/issues/1835,358333272,MDEyOklzc3VlQ29tbWVudDM1ODMzMzI3Mg==,10512793,2018-01-17T15:08:17Z,2018-01-17T15:08:17Z,CONTRIBUTOR,"Thanks for the advice @shoyer I've moved the warning to NetCDF4DataStore.open() and reverted backends/api.py back to the original. I've used LooseVersion for the version comparison and made the pep8 change. There is a problem with the test. I've added the test to NetCDF4DataTest. However, when the filename has 88 characters the seg fault occurs and the test gets stopped. The output from ``` $py.test tests/test_backends.py ``` is just: ``` ============================= test session starts ============================== platform linux -- Python 3.6.2, pytest-3.2.1, py-1.4.34, pluggy-0.4.0 rootdir: /my_python_path/xarray, inifile: pytest.ini plugins: pylama-7.4.3 collected 1042 items tests/test_backends.py . *** Error in `/path_to/python': double free or corruption (!prev): *** Aborted (core dumped) ``` If the filename doesn't have 88 characters then the test result is ""Failed: DID NOT WARN."", which is fine as it shouldn't trigger the warning. I've been trying to see how people handle this issue, but haven't been able to find examples of people trying to trigger seg faults in a test yet","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,288957853