html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1423#issuecomment-303657265,https://api.github.com/repos/pydata/xarray/issues/1423,303657265,MDEyOklzc3VlQ29tbWVudDMwMzY1NzI2NQ==,1392657,2017-05-24T08:37:57Z,2017-05-24T08:37:57Z,CONTRIBUTOR,"TIL, thanks!

On Wed, May 24, 2017 at 10:34 AM, Stephan Hoyer <notifications@github.com>
wrote:

> *@shoyer* commented on this pull request.
> ------------------------------
>
> In xarray/tests/__init__.py
> <https://github.com/pydata/xarray/pull/1423#discussion_r118193430>:
>
> >              yield
> -            assert len(w) > 0
> -            assert any(message in str(wi.message) for wi in w)
> +        assert len(w) > 0
>
> Yes, this was intentional. Python with blocks don't define scopes for
> variables, so w is still defined outside the block. In this case, the with
> block only indicates where warnings should be caught.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/pydata/xarray/pull/1423#discussion_r118193430>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ABVAESisUh7dTNsp3l4OryHoCGuJPb2gks5r8-uugaJpZM4Nkq_Z>
> .
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,230937851