html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/7739#issuecomment-1515142339,https://api.github.com/repos/pydata/xarray/issues/7739,1515142339,IC_kwDOAMm_X85aTzzD,12465248,2023-04-19T17:55:16Z,2023-04-19T17:55:16Z,CONTRIBUTOR,"I followed `data =  True / False / ""array"" / ""list""`
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1659078413
https://github.com/pydata/xarray/pull/7739#issuecomment-1514700581,https://api.github.com/repos/pydata/xarray/issues/7739,1514700581,IC_kwDOAMm_X85aSH8l,12465248,2023-04-19T13:04:19Z,2023-04-19T13:04:19Z,CONTRIBUTOR,"Making all the requested changes, the above should resolve momentarily.

I like this ""trick""/suggestion:

```
And a design question/suggestion: what about instead of adding another kwarg, you could use data = True / False / ""numpy""?
```

I will implement this if we are in agreement with @dcherian 
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1659078413
https://github.com/pydata/xarray/pull/7739#issuecomment-1511459288,https://api.github.com/repos/pydata/xarray/issues/7739,1511459288,IC_kwDOAMm_X85aFwnY,12465248,2023-04-17T14:22:50Z,2023-04-17T14:22:50Z,CONTRIBUTOR,"I'm happy to ""fix"" the mypy issues, but it's on that I suspect might be requested for changes (if I recall correctly, it's just in the tests)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1659078413
https://github.com/pydata/xarray/pull/7739#issuecomment-1504309371,https://api.github.com/repos/pydata/xarray/issues/7739,1504309371,IC_kwDOAMm_X85ZqfB7,12465248,2023-04-12T00:13:03Z,2023-04-12T00:13:03Z,CONTRIBUTOR,"i kinda implied, but I'll just state that the extra code to test equality of encodings is not handsome.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1659078413
https://github.com/pydata/xarray/pull/7739#issuecomment-1504297701,https://api.github.com/repos/pydata/xarray/issues/7739,1504297701,IC_kwDOAMm_X85ZqcLl,12465248,2023-04-12T00:03:23Z,2023-04-12T00:03:23Z,CONTRIBUTOR,"@dcherian thanks! I didnt incoroprate any suggestions yet. 
regarding the inequality of encodings of datasets is obscured by `assert_identical(a, b)` not evaluating encodings. it seems like it should have an option to also check encodings (or not). ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1659078413
https://github.com/pydata/xarray/pull/7739#issuecomment-1504241169,https://api.github.com/repos/pydata/xarray/issues/7739,1504241169,IC_kwDOAMm_X85ZqOYR,12465248,2023-04-11T23:09:57Z,2023-04-11T23:09:57Z,CONTRIBUTOR,"In the off-hand chance this is reviewed before I push again, do not merge. I have a fix to encodings not getting properly roundtripped in Ds.from_dict(ds.to_dict). it was minor to fix but making sure it's tested will take a min","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1659078413
https://github.com/pydata/xarray/pull/7739#issuecomment-1500720650,https://api.github.com/repos/pydata/xarray/issues/7739,1500720650,IC_kwDOAMm_X85Zcy4K,12465248,2023-04-07T23:27:25Z,2023-04-07T23:27:25Z,CONTRIBUTOR,I solved the mypy errors in a highly dubious way. 👀 ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1659078413
https://github.com/pydata/xarray/pull/7739#issuecomment-1500558818,https://api.github.com/repos/pydata/xarray/issues/7739,1500558818,IC_kwDOAMm_X85ZcLXi,12465248,2023-04-07T19:07:35Z,2023-04-07T19:07:35Z,CONTRIBUTOR,"I would appreciate any edification on the Mypy failures. Looking at the indicated lines, i'm 🤷 .","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,1659078413