home / github / commits

Menu
  • GraphQL API
  • Search all tables

commits: c9b9eec73a033e275b6012e7d391dd42591ccf52

This data as json

sha message author_date committer_date raw_author raw_committer repo author committer
c9b9eec73a033e275b6012e7d391dd42591ccf52 Use explicit type check in `as_compatible_data` instead of blanket access to `values` attribute (#2905) * In as_compatible_data, check explicitly for nested self-described types This change was prompted by the fact that `getattr(data, 'values', data)` affected any kind of data with a `values` attribute, which is not the desired behaviour at that point. This also extends tests to assert that custom objects with such an attribute are not attempted to be converted * Add whats-new entry * Remove trailing whitespace * In as_compatible_data, check explicitly for nested self-described types This change was prompted by the fact that `getattr(data, 'values', data)` affected any kind of data with a `values` attribute, which is not the desired behaviour at that point. This also extends tests to assert that custom objects with such an attribute are not attempted to be converted * whats-new * Fix test. * Update @blsqr github URL in whats-new * actually check that values is not extracted Co-authored-by: dcherian <deepak@cherian.net> Co-authored-by: Keewis <keewis@posteo.de> 2021-02-18T15:04:14Z 2021-02-18T15:04:14Z c5fcf7d45fa558ddab70a0bea43b7274356dd001 cd792325681cbad9f663f2879d8b69f1edbb678f 13221727 1700203 19864447
Powered by Datasette · Queries took 1.339ms · About: xarray-datasette